x11/guake: Update to version 3.7.0
Needs ReviewPublic
Actions

Authored by daniel_shafer.cc on Aug 1 2021, 9:22 AM.

Details

Reviewers

tcberner
koobs

Summary

x11/guake: Update to version 3.7.0

Changes can be viewed on the Guake release page:
https://github.com/Guake/guake/releases

The biggest difference is the removal of the data
directory from pypi, which now requires we compile
the gschemas file post-install.

Test Plan

portlint: WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
0 fatal errors and 1 warning found. (There is no way around this, Guake requires gettext regardless).

poudriere: (testport, 13Samd64, good)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 40786
Build 37675: arc lint + arc unit

Event Timeline

daniel_shafer.cc created this revision.Aug 1 2021, 9:22 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptAug 1 2021, 9:22 AM

daniel_shafer.cc requested review of this revision.Aug 1 2021, 9:22 AM

Harbormaster completed remote builds in B40786: Diff 93069.Aug 1 2021, 9:22 AM

daniel_shafer.cc edited the summary of this revision. (Show Details)Aug 1 2021, 9:22 AM

daniel_shafer.cc edited the summary of this revision. (Show Details)

Forgot to remove the old SVN $FreeBSD$ tag.

Harbormaster completed remote builds in B40787: Diff 93070.Aug 1 2021, 9:25 AM

tcberner requested changes to this revision.Aug 1 2021, 9:26 AM

tcberner added a subscriber: tcberner.

tcberner added inline comments.

x11/guake/Makefile
1	^ no longer a thing
x11/guake/pkg-plist
4	^ hardcoded python-version

This revision now requires changes to proceed.Aug 1 2021, 9:26 AM

daniel_shafer.cc edited the test plan for this revision. (Show Details)Aug 1 2021, 9:28 AM

daniel_shafer.cc added a reviewer: koobs.

daniel_shafer.cc edited the test plan for this revision. (Show Details)

Removed hard coded Python version as pointed out by @tcberner

Harbormaster completed remote builds in B40788: Diff 93071.Aug 1 2021, 9:37 AM

Suse also carries this patch which may be of interest?
https://build.opensuse.org/package/view_file/openSUSE:Factory/guake/guake-follow-focus-with-dual-monitors.patch?expand=1

x11/guake/Makefile
4	PORTVERSION --> DISTVERSION (if you are going to follow Porter's Handbook)
30	Upstream disagrees, https://github.com/Guake/guake/blob/3.7.0/requirements.txt#L14 (oldest version we have in tree is 3.6)