Page MenuHomeFreeBSD
Differential D3798

New port: databases/jlog
AbandonedPublic
Actions

Authored by alfred on Oct 4 2015, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 10:06 PM
Unknown Object (File)
Wed, Nov 5, 11:45 AM
Unknown Object (File)
Sat, Nov 1, 10:11 PM
Unknown Object (File)
Fri, Oct 31, 1:20 AM
Unknown Object (File)
Wed, Oct 29, 8:26 AM
Unknown Object (File)
Mon, Oct 27, 2:25 AM
Unknown Object (File)
Sun, Oct 26, 8:31 AM
Unknown Object (File)
Sun, Oct 26, 6:45 AM
View All Files
Subscribers
mat

Details

Reviewers
koobs
mat
Group Reviewers
Ports Committers
Perl
Summary

Proposed commit message:

databases/jlog: New Journaled log port

JLog is short for "journaled log" and this package is really an API and implementation that is libjlog.
libjlog is a pure C, very simple durable message queue with multiple subscribers and publishers (both thread and multi-process safe).

WWW: https://labs.omniti.com/labs/jlog

DiffRev: https://reviews.freebsd.org/D3798
Submitted by: Alfred Perlstein (alfred@, maintainer)
Reviewed_by: 
Approved by:
Test Plan
  • portlint -AC (include output)
  • poudriere testport (upload or link poudriere log)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 737
Build 737: arc lint + arc unit

Event Timeline

alfred updated this revision to Diff 9133.Oct 4 2015, 6:18 PM
alfred retitled this revision from to New port: databases/jlog.
alfred updated this object.
alfred edited the test plan for this revision. (Show Details)
alfred added reviewers: Ports Committers, koobs.Oct 6 2015, 8:32 PM
alfred updated this revision to Diff 9302.Oct 10 2015, 6:42 PM
  • portlint: regent distinfo and cleanup github directives
  • shebang fixes
brnrd updated this object.Oct 10 2015, 7:30 PM
brnrd edited the test plan for this revision. (Show Details)
brnrd added a subscriber: brnrd.EditedOct 10 2015, 7:34 PM

Had to regenerate the distinfo{F253545} and modified the Makefile{F253549} to adapt to the new OPTIONS-helpers. Looks much cleaner I think.

  • Update review's Summary and Test plan
  • Update distinfo
  • Remove GH_COMMIT, replace with GH_TAGNAME
  • Add dependency on autoconf-2.13
  • FIx shebangs (USES= shebangs)
  • Fix perl packlist (USES= perl5)
  • Refactor all conditionals to OPTIONS framework

Hope this helps you.

alfred updated this revision to Diff 9315.Oct 11 2015, 2:50 PM
  • Fix all the things (from brnrd@)
  • Fixup for portlint -AC
brnrd added a reviewer: brnrd.Oct 11 2015, 5:25 PM
brnrd removed a subscriber: brnrd.
brnrd added inline comments.Oct 11 2015, 5:34 PM
databases/jlog/Makefile
7

I'd guess 1.2.2 with a counter for the PORTREVISION would do just fine

22
# cf3085fe contains c++ fixes and other additions over the 1.2.2 release
36

Will ${PERL} always resolve to perl ? Otherwise it'll break if there's any chance that it'll be something other than configure expexts. If perl is on this is added to CONFIGURE_ARGS as --with-perl (and --without-perl when off)

41

This can be removed

alfred marked an inline comment as done.Oct 11 2015, 5:51 PM

OK about to resubmit.

databases/jlog/Makefile
7

Yes, but this isn't 1.2.2, it's a point in time release that we need. It's actually 1.2.2+commits until 201512200

22

ok

36

moving back to "perl" but portlint will complain

alfred updated this revision to Diff 9316.Oct 11 2015, 5:54 PM
  • Cleanup comment, remove extra include, fix PERL
alfred updated this revision to Diff 9318.Oct 11 2015, 6:33 PM
  • remove .packlist from plist, not needed
brnrd accepted this revision.Oct 11 2015, 6:34 PM
brnrd edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 11 2015, 6:34 PM
koobs requested changes to this revision.Oct 13 2015, 11:54 AM
koobs edited edge metadata.
koobs added inline comments.
databases/jlog/Makefile
8

What does 's' stand for?

Might just a datestamp suffix suffice?

13

Add LICENSE_FILE if one exists in WRKSRC

15

Does it *actually* depend on and "call" a specific autoconf version-suffixed binary?

If not, set depends to version-less autoconf, OR what about USE_AUTOTOOLS=autoconf?

May be worth consider patching if currently checks for, but doesnt *require* 2.13.

20

If I recall correctly, PORTNAME is the default for GH_PROJECT.

26

USES=perl5, but PERL is an option?

Perhaps you meant USES=perl5:build only?

37

Are you sure you dont want to use USES=autoreconf here?

See if you can kill this custom pre-configure target. My guess is its not really needed.

This revision now requires changes to proceed.Oct 13 2015, 11:54 AM
koobs added a reviewer: Perl.Oct 13 2015, 11:55 AM
mat requested changes to this revision.Oct 13 2015, 2:00 PM
mat added a reviewer: mat.
mat added a subscriber: mat.
mat added inline comments.
databases/jlog/Makefile
8
$ git describe cf3085f --tags
1.2.2-24-gcf3085f

There a 1.2.2 tag in the github repository, so, you would be better of setting DISTVERSION=1.2.2-24-gcf3085f

15

This feels so wrong.

28

There is only one option, PERL, and there is no %%PERL%% in the plist, you can drop this line.

37

Yeah, use USES=autoreconf.

37

portlint complains, it is what it does, it does not mean you have to blinly follow what it tells you :-)

brnrd added a comment.Jan 1 2016, 8:31 PM

Closed by rP399111

brnrd resigned from this revision.Feb 14 2016, 8:35 PM
brnrd removed a reviewer: brnrd.

alfred@ long committed this to ports

alfred abandoned this revision.Feb 14 2016, 9:01 PM

This is committed.

Revision Contents
Changeset List

PathSize
databases/
1 line
jlog/
50 lines
2 lines
files/
11 lines
10 lines
11 lines
15 lines

Diff 9302

View Options

databases/Makefile

Loading...
View Options

databases/jlog/Makefile

Loading...
View Options

databases/jlog/distinfo

Loading...
View Options

databases/jlog/files/patch-Makefile.in

Loading...
View Options

databases/jlog/files/patch-jlog_io.c

Loading...
View Options

databases/jlog/pkg-descr

Loading...
View Options

databases/jlog/pkg-plist

Loading...