tools/build: Don't redefine open() for the linux bootstrap
ClosedPublic
Actions

Authored by arichardson on Jul 20 2021, 12:25 AM.

Details

Reviewers

jrtc27
dim

Commits

rG85c76b41178c: tools/build: Don't redefine open() for the linux bootstrap
rG5f6c8ce2452d: tools/build: Don't redefine open() for the linux bootstrap

Summary

This is needed to bootstrap llvm-tblgen on Linux since LLVM calls
::open(...) which does not work if open is a statement macro.
Also stop defining O_SHLOCK/O_EXLOCK and update the only bootstrap tools
user of those flags to deal with missing definitions.

Split out from D31057

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40544
Build 37433: arc lint + arc unit

Event Timeline

arichardson created this revision.Jul 20 2021, 12:25 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 20 2021, 12:25 AM

arichardson requested review of this revision.Jul 20 2021, 12:25 AM

Harbormaster completed remote builds in B40544: Diff 92450.Jul 20 2021, 12:25 AM

arichardson added a child revision: D31057: Allow bootstrapping llvm-tblgen on macOS and Linux.Jul 20 2021, 12:25 AM

jrtc27 added inline comments.Jul 20 2021, 12:39 AM

lib/libc/db/db/db.c
68	You missed dropping these changes
tools/build/cross-build/include/linux/fcntl.h
46–49	How come this is going away?

arichardson added inline comments.Jul 20 2021, 12:42 AM

tools/build/cross-build/include/linux/fcntl.h
46–49	That should have been removed as part of the initial commit since it's in `__unused_workaround_end.h`. Forgot to remove that one when I moved it into a separate header.