tcp: When rack or bbr get a pullup failure in the common code, don't free the NULL mbuf.
ClosedPublic
Actions

Authored by rrs on Jul 15 2021, 3:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 4, 12:34 AM

	Unknown Object (File)
	Fri, Sep 4, 12:26 AM

	Unknown Object (File)
	Wed, Aug 12, 9:17 PM

	Unknown Object (File)
	Wed, Aug 12, 7:49 AM

	Unknown Object (File)
	Aug 7 2026, 9:48 PM

	Unknown Object (File)
	Aug 7 2026, 5:59 PM

	Unknown Object (File)
	Aug 6 2026, 1:18 PM

	Unknown Object (File)
	Aug 6 2026, 1:04 PM

View All Files

Subscribers

melifaro

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the…

Summary

There is a bug in the error path where rack_bbr_common does a m_pullup() and the pullup fails.
There is a stray mfree(m) after m is set to NULL. This is not a good idea :-)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rrs created this revision.Jul 15 2021, 3:09 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJul 15 2021, 3:09 PM

Herald added a subscriber: melifaro. · View Herald Transcript

rrs requested review of this revision.Jul 15 2021, 3:09 PM

tuexen accepted this revision.Jul 16 2021, 10:43 AM

This revision is now accepted and ready to land.Jul 16 2021, 10:43 AM

Closed by commit rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the… (authored by rrs). · Explain WhyJul 16 2021, 6:01 PM

This revision was automatically updated to reflect the committed changes.

rrs added a commit: rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the….

Committed

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack_bbr_common.c

2 lines

Diff 92287

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

tcp: When rack or bbr get a pullup failure in the common code, don't free the NULL mbuf.ClosedPublicActions