Fix to call callout_init with correct inputs from axp driver
ClosedPublic
Actions

Authored by rajeshasp on Jul 8 2021, 2:57 AM.

Details

Reviewers

vmaffione
gallatin
• hselasky

Commits

rG0fd05b0173e2: Fix to call callout_init with correct inputs from axp driver

Summary

callout_init takes the second parameter as a flag to indicate MPSAFE.
axp(4) driver passes unwanted "hz" reference. This patch removes it.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40383
Build 37272: arc lint + arc unit

Event Timeline

rajeshasp created this revision.Jul 8 2021, 2:57 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 8 2021, 2:57 AM

rajeshasp requested review of this revision.Jul 8 2021, 2:57 AM

Harbormaster completed remote builds in B40383: Diff 91959.Jul 8 2021, 2:57 AM

rajeshasp added a subscriber: • hselasky.Jul 8 2021, 3:06 AM

• hselasky accepted this revision.Jul 8 2021, 6:44 AM

This revision is now accepted and ready to land.Jul 8 2021, 6:44 AM

gallatin accepted this revision.Jul 8 2021, 8:03 PM

LGTM!

Closed by commit rG0fd05b0173e2: Fix to call callout_init with correct inputs from axp driver (authored by rajeshasp). · Explain WhyJul 13 2021, 2:40 PM

This revision was automatically updated to reflect the committed changes.

rajeshasp added a commit: rG0fd05b0173e2: Fix to call callout_init with correct inputs from axp driver.

Thanks everyone. Pushed upstream today. Sorry about the delay in pushing it.

Revision Contents
Changeset List

Path

Size

sys/

dev/

axgbe/

if_axgbe_pci.c

2 lines

Diff 91959

View Options

sys/dev/axgbe/if_axgbe_pci.c

Fix to call callout_init with correct inputs from axp driverClosedPublicActions