Page MenuHomeFreeBSD

usr.bin/diff: fix UBSan error in readhash
ClosedPublic

Authored by arichardson on Jul 6 2021, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 12, 5:43 AM
Unknown Object (File)
Jan 13 2024, 3:35 PM
Unknown Object (File)
Dec 20 2023, 5:11 AM
Unknown Object (File)
Dec 11 2023, 7:32 AM
Unknown Object (File)
Sep 16 2023, 12:13 AM
Unknown Object (File)
Jul 17 2023, 10:40 PM
Unknown Object (File)
Jul 4 2023, 7:19 AM
Unknown Object (File)
May 12 2023, 8:33 PM
Subscribers

Details

Summary

UBSan complains about the sum = sum * 127 + chrtran(t); line below since
that can overflow an int. Use unsigned int instead to ensure that
overflow is well-defined.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40347
Build 37236: arc lint + arc unit