Page MenuHomeFreeBSD

usr.bin/diff: fix UBSan error in readhash
ClosedPublic

Authored by arichardson on Jul 6 2021, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 15, 2:44 AM
Unknown Object (File)
Fri, Aug 14, 4:21 PM
Unknown Object (File)
Sun, Aug 9, 6:25 PM
Unknown Object (File)
Sun, Aug 9, 6:25 PM
Unknown Object (File)
Fri, Aug 7, 8:12 PM
Unknown Object (File)
Fri, Aug 7, 4:36 AM
Unknown Object (File)
Thu, Aug 6, 7:55 AM
Unknown Object (File)
Wed, Aug 5, 4:27 AM
Subscribers

Details

Summary

UBSan complains about the sum = sum * 127 + chrtran(t); line below since
that can overflow an int. Use unsigned int instead to ensure that
overflow is well-defined.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40347
Build 37236: arc lint + arc unit