Page MenuHomeFreeBSD
Differential D31075

usr.bin/diff: fix UBSan error in readhash
ClosedPublic
Actions

Authored by arichardson on Jul 6 2021, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 5:09 AM
Unknown Object (File)
Fri, Oct 17, 11:36 PM
Unknown Object (File)
Wed, Oct 15, 2:13 AM
Unknown Object (File)
Wed, Oct 15, 2:13 AM
Unknown Object (File)
Wed, Oct 15, 2:13 AM
Unknown Object (File)
Tue, Oct 14, 5:18 PM
Unknown Object (File)
Sun, Oct 12, 3:29 AM
Unknown Object (File)
Sep 21 2025, 10:15 AM
View All 72 Files
Subscribers
imp

Details

Reviewers
bapt
kevans
imp
Commits
rG7a7324d9cebe: usr.bin/diff: fix UBSan error in readhash
rGc78f449d85e0: usr.bin/diff: fix UBSan error in readhash
Summary

UBSan complains about the sum = sum * 127 + chrtran(t); line below since
that can overflow an int. Use unsigned int instead to ensure that
overflow is well-defined.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40347
Build 37236: arc lint + arc unit

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
2 lines

Diff 91872

View Options

usr.bin/diff/diffreg.c

Loading...