libpfctl: improve DIOCGETSTATESNV size estimation
AbandonedPublic
Actions

Authored by kp on Jun 29 2021, 7:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 11, 3:04 AM

	Unknown Object (File)
	Mon, May 11, 2:13 AM

	Unknown Object (File)
	Sun, May 10, 11:35 PM

	Unknown Object (File)
	Sat, May 9, 4:54 PM

	Unknown Object (File)
	Mon, May 4, 3:05 PM

	Unknown Object (File)
	Thu, Apr 30, 8:18 AM

	Unknown Object (File)
	Thu, Apr 30, 3:50 AM

	Unknown Object (File)
	Thu, Apr 30, 3:50 AM

View All Files

Subscribers

donner

imp

Details

Reviewers

donner

Group Reviewers

network
pfsense

Summary

Each state entry is around 2K of data. Use this as a minimum size to
reduce the number of attempts we have to make to grow the buffer to the
required size.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40172
Build 37061: arc lint + arc unit

Event Timeline

kp created this revision.Jun 29 2021, 7:38 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 29 2021, 7:38 PM

kp requested review of this revision.Jun 29 2021, 7:38 PM

Harbormaster completed remote builds in B40172: Diff 91522.Jun 29 2021, 7:38 PM

kp added a parent revision: D30944: pf: Reduce the data returned in DIOCGETSTATESNV.Jun 29 2021, 7:38 PM

kp added a child revision: D30946: pf: getstates: avoid taking the hashrow lock if the row is empty.

LGTM

This revision is now accepted and ready to land.Jun 30 2021, 3:23 PM

(Will be replaced by a different, more dynamic approach.)

Revision Contents
Changeset List

Path

Size

lib/

libpfctl/

libpfctl.c

3 lines

Diff 91522

View Options

libpfctl: improve DIOCGETSTATESNV size estimationAbandonedPublicActions