Page MenuHomeFreeBSD
Differential D30872

amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS
ClosedPublic
Actions

Authored by kib on Jun 22 2021, 11:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 26, 11:01 PM
Unknown Object (File)
Sat, Jul 25, 2:43 AM
Unknown Object (File)
Thu, Jul 23, 3:37 PM
Unknown Object (File)
Wed, Jul 22, 5:34 PM
Unknown Object (File)
Tue, Jul 21, 12:19 PM
Unknown Object (File)
Mon, Jul 20, 6:26 AM
Unknown Object (File)
Thu, Jul 16, 2:42 AM
Unknown Object (File)
Fri, Jul 10, 8:25 AM
View All Files
Subscribers
None

Details

Reviewers
jhb
markj
Commits
rG33e1287b6a54: amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Jun 22 2021, 11:46 PM
kib created this revision.
markj accepted this revision.Jun 23 2021, 1:10 PM
markj added inline comments.
sys/amd64/amd64/machdep.c
1183

I think it would be better to explicitly cast the address, i.e., (unsigned short *)0x472.

It seems like a strange place to do this operation. hammer_time() already checks for MODINFOMD_EFI_MAP to see if vty_set_preferred() should be called; we could do the same check earlier in order to set the BIOS flag, and perhaps save the result to avoid a second preload_search_info() call.

This revision is now accepted and ready to land.Jun 23 2021, 1:10 PM
kib updated this revision to Diff 91274.Jun 23 2021, 8:01 PM

Move the write to hammer_time()

This revision now requires review to proceed.Jun 23 2021, 8:01 PM
markj accepted this revision.Jun 23 2021, 8:29 PM
This revision is now accepted and ready to land.Jun 23 2021, 8:29 PM
Closed by commit rG33e1287b6a54: amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS (authored by kib). · Explain WhyJun 23 2021, 9:50 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG33e1287b6a54: amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
3 lines
12 lines

Diff 91274

View Options

sys/amd64/amd64/locore.S

Loading...
View Options

sys/amd64/amd64/machdep.c

Loading...