Paths

Table of Contentst

Differential D30872

amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS
ClosedPublic
Actions

Authored by kib on Jun 22 2021, 11:46 PM.

Tags

None

Referenced Files

	F149537146: D30872.id91274.diff
	Wed, Mar 25, 2:45 AM

	Unknown Object (File)
	Tue, Mar 24, 3:46 AM

	Unknown Object (File)
	Thu, Mar 19, 5:46 AM

	Unknown Object (File)
	Wed, Mar 18, 5:24 AM

	Unknown Object (File)
	Wed, Mar 18, 5:23 AM

	Unknown Object (File)
	Sun, Mar 15, 2:51 AM

	Unknown Object (File)
	Sat, Mar 14, 5:26 PM

	Unknown Object (File)
	Sat, Mar 14, 3:30 PM

Subscribers

None

Details

Reviewers

jhb
markj

Commits

rG33e1287b6a54: amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib requested review of this revision.Jun 22 2021, 11:46 PM

kib created this revision.

markj accepted this revision.Jun 23 2021, 1:10 PM

markj added inline comments.

sys/amd64/amd64/machdep.c
1183	I think it would be better to explicitly cast the address, i.e., `(unsigned short *)0x472`. It seems like a strange place to do this operation. hammer_time() already checks for MODINFOMD_EFI_MAP to see if vty_set_preferred() should be called; we could do the same check earlier in order to set the BIOS flag, and perhaps save the result to avoid a second preload_search_info() call.

This revision is now accepted and ready to land.Jun 23 2021, 1:10 PM

Move the write to hammer_time()

This revision now requires review to proceed.Jun 23 2021, 8:01 PM

markj accepted this revision.Jun 23 2021, 8:29 PM

This revision is now accepted and ready to land.Jun 23 2021, 8:29 PM

Closed by commit rG33e1287b6a54: amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS (authored by kib). · Explain WhyJun 23 2021, 9:50 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG33e1287b6a54: amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

3 lines

12 lines

Diff 91274

sys/amd64/amd64/locore.S

Loading...

sys/amd64/amd64/machdep.c

Loading...