Page MenuHomeFreeBSD
Differential D30418

LinuxKPI: byteorder.h
ClosedPublic
Actions

Authored by bz on May 24 2021, 6:08 PM.
Tags
None
Referenced Files
F132327671: D30418.id89858.diff
Wed, Oct 15, 10:45 PM
F132245212: D30418.id89782.diff
Wed, Oct 15, 3:43 AM
Unknown Object (File)
Tue, Oct 14, 6:51 PM
Unknown Object (File)
Tue, Oct 14, 4:14 PM
Unknown Object (File)
Tue, Oct 14, 4:10 PM
Unknown Object (File)
Tue, Oct 14, 2:02 PM
Unknown Object (File)
Tue, Oct 14, 1:51 PM
Unknown Object (File)
Tue, Oct 14, 1:50 PM
View All Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
• hselasky
Group Reviewers
linuxkpi
Commits
rGd8310b668b25: LinuxKPI: byteorder.h
rG5aeeab54b0e1: LinuxKPI: byteorder.h
Summary

Add a few more le<n>_{tp,add}_cpu*() #defines/functions found in
wireless drivers.

Sponsored by: The FreeBSD Foundation
MFC After: 2 weeks
Reviewed by:
Differential Revision:

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39388
Build 36277: arc lint + arc unit

Event Timeline

bz created this revision.May 24 2021, 6:08 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMay 24 2021, 6:08 PM
bz requested review of this revision.May 24 2021, 6:08 PM
Harbormaster completed remote builds in B39388: Diff 89742.May 24 2021, 6:08 PM
emaste added inline comments.May 24 2021, 6:34 PM
sys/compat/linuxkpi/common/include/asm/byteorder.h
57–59

minor pedantic point, should these sort beside their other existing names, e.g. __le16_to_cpu following le16_to_cpu?

• hselasky added a subscriber: • hselasky.May 24 2021, 7:21 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/asm/byteorder.h
86

No need for extra parenthesis here!

((x)) -> (x)

bz added inline comments.May 24 2021, 8:46 PM
sys/compat/linuxkpi/common/include/asm/byteorder.h
57–59

Should we just add all combinations whether or not Linux does or we'll need them and be done?

bz updated this revision to Diff 89782.May 24 2021, 10:01 PM

Reshuffle and fill all the gaps as (partialy) suggested by @emaste
(as I understood it at least).

bz marked 2 inline comments as done.May 24 2021, 10:02 PM
Harbormaster completed remote builds in B39420: Diff 89782.May 24 2021, 10:02 PM
• hselasky accepted this revision.May 25 2021, 7:40 AM
This revision is now accepted and ready to land.May 25 2021, 7:40 AM
bz added inline comments.May 25 2021, 3:38 PM
sys/compat/linuxkpi/common/include/asm/byteorder.h
60

There's a bug here. I'll fix that before committing.

Closed by commit rG5aeeab54b0e1: LinuxKPI: byteorder.h (authored by bz). · Explain WhyMay 25 2021, 6:16 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG5aeeab54b0e1: LinuxKPI: byteorder.h.
bz added a commit: rGd8310b668b25: LinuxKPI: byteorder.h.Jul 18 2021, 12:38 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
asm/
17 lines

Diff 89742

View Options

sys/compat/linuxkpi/common/include/asm/byteorder.h

Loading...