extres: regulator: Fix regulator_status for already enable regulators
ClosedPublic
Actions

Authored by manu on May 16 2021, 3:16 PM.

Details

Reviewers

Group Reviewers

ARM
arm64

Commits

rG1e372b049426: extres: regulator: Fix regulator_status for already enable regulators
rGf52072b06da7: extres: regulator: Fix regulator_status for already enable regulators

Summary

If a regulator hasn't been enable by a driver but is enabled in hardware
(most likely enabled by U-Boot), regulator_status will returns that it
is enabled and so any call to regulator_disable will panic as it wasn't
enabled by one of our drivers.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu requested review of this revision.May 16 2021, 3:16 PM

manu created this revision.

This revision was not accepted when it landed; it landed in state Needs Review.May 21 2021, 4:06 PM

Closed by commit rGf52072b06da7: extres: regulator: Fix regulator_status for already enable regulators (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGf52072b06da7: extres: regulator: Fix regulator_status for already enable regulators.

IMHO, this is wrong change. regulator_status() must report physical state of regulator - if given deice is powered or not. the mmc power sequencer should use similar technique as backlight. But seems like this kind of usage is common - so we can expand regulator framework with uncounted function -> something like regulator_on()/regulator_off()

manu added a commit: rG1e372b049426: extres: regulator: Fix regulator_status for already enable regulators.Jul 22 2021, 5:17 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

extres/

regulator/

regulator.c

4 lines

Diff 89300

View Options

sys/dev/extres/regulator/regulator.c

extres: regulator: Fix regulator_status for already enable regulatorsClosedPublicActions