pf tests: More set skip on <ifgroup> tests
ClosedPublic
Actions

Authored by kp on May 16 2021, 10:46 AM.

Details

Reviewers

None

Group Reviewers

Commits

rGb780106bba6a: pf tests: More set skip on <ifgroup> tests
rG25fa4b8e668f: pf tests: More set skip on <ifgroup> tests
rG45db38554517: pf tests: More set skip on <ifgroup> tests

Summary

Test the specific case reported in PR 255852. Clearing the skip flag
on groups was broken because pfctl couldn't work out if a kif was a
group or not, because the kernel no longer set the pfik_group pointer.

PR: 255852
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39218
Build 36107: arc lint + arc unit

Event Timeline

kp created this revision.May 16 2021, 10:46 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptMay 16 2021, 10:46 AM

kp requested review of this revision.May 16 2021, 10:46 AM

kp added a parent revision: D30284: pf: Set the pfik_group for userspace.

Harbormaster completed remote builds in B39218: Diff 89291.May 16 2021, 10:46 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2021, 1:50 PM

Closed by commit rG45db38554517: pf tests: More set skip on <ifgroup> tests (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG45db38554517: pf tests: More set skip on <ifgroup> tests.

kp added a commit: rG25fa4b8e668f: pf tests: More set skip on <ifgroup> tests.May 24 2021, 3:41 PM

kp added a commit: rGb780106bba6a: pf tests: More set skip on <ifgroup> tests.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

set_skip.sh

46 lines

Diff 89291

View Options

tests/sys/netpfil/pf/set_skip.sh

pf tests: More set skip on <ifgroup> testsClosedPublicActions