Differential D3724

Fix non-POSIX-compliant use of getaddrinfo in libfetch
ClosedPublic
Actions

Authored by grembo on Sep 23 2015, 2:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 21, 12:57 AM

	Unknown Object (File)
	Mon, Oct 20, 6:31 PM

	Unknown Object (File)
	Fri, Oct 17, 10:03 AM

	Unknown Object (File)
	Fri, Oct 17, 2:55 AM

	Unknown Object (File)
	Thu, Oct 9, 6:30 AM

	Unknown Object (File)
	Sep 28 2025, 9:37 AM

	Unknown Object (File)
	Sep 25 2025, 1:11 PM

	Unknown Object (File)
	Sep 25 2025, 2:28 AM

Subscribers

Details

Reviewers

bapt
des

Commits

rS288217: Fix non-POSIX-compliant use of getaddrinfo in libfetch

Summary

Boris Kolpackov brought this to my attention: libfetch uses
getaddrinfo in a non-compliant way, as it assumes that
res will be NULL when getaddrinfo fails. Even this
is true in reality right now, it's neither guaranteed by
POSIX, nor by the getaddrinfo man page. To prevent future
breakage and to be a good citizen, this patch aims
to fix this.

Test Plan

Build.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 591
Build 591: arc lint + arc unit

Event Timeline

grembo updated this revision to Diff 8910.Sep 23 2015, 2:42 PM

grembo retitled this revision from to Fix non-POSIX-compliant use of getaddrinfo in libfetch.

grembo updated this object.

grembo edited the test plan for this revision. (Show Details)

grembo added reviewers: des, bapt.

Herald added a subscriber: imp. · View Herald TranscriptSep 23 2015, 2:42 PM

bapt accepted this revision.Sep 23 2015, 10:03 PM

bapt edited edge metadata.

This revision is now accepted and ready to land.Sep 23 2015, 10:03 PM

Closed by commit rS288217: Fix non-POSIX-compliant use of getaddrinfo in libfetch (authored by grembo). · Explain WhySep 25 2015, 2:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

3 lines

Diff 8910

lib/libfetch/common.c

Loading...