Page MenuHomeFreeBSD
Differential D30169

rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen
ClosedPublic
Actions

Authored by otis on May 7 2021, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 6, 8:25 AM
Unknown Object (File)
Mon, Apr 6, 5:03 AM
Unknown Object (File)
Sun, Apr 5, 12:52 PM
Unknown Object (File)
Sun, Apr 5, 11:03 AM
Unknown Object (File)
Sun, Apr 5, 10:02 AM
Unknown Object (File)
Sun, Apr 5, 7:07 AM
Unknown Object (File)
Sat, Apr 4, 6:59 PM
Unknown Object (File)
Sat, Apr 4, 7:24 AM
View All Files
Subscribers
andrew
imp
manu
Contributor Reviews (src)

Details

Reviewers
manu
Commits
rGc988a558fafe: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen
rG0f12b394faa1: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen
rGe7cd56cfe037: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen
rGc2c9ef3cedf6: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen
Summary

Recognize also raspberrypi,firmware-ts (7" RPi touchscreen display) in
addition to rpi,ft-5406.

Also, move the driver from ofwbus to simplebus.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

otis created this revision.May 7 2021, 9:50 PM
Herald added subscribers: Contributor Reviews (src), andrew, imp. · View Herald TranscriptMay 7 2021, 9:50 PM
otis requested review of this revision.May 7 2021, 9:50 PM
Harbormaster completed remote builds in B39079: Diff 88877.May 7 2021, 9:50 PM
otis updated this revision to Diff 88878.May 7 2021, 9:52 PM
  • rpi_ft5406: Reduce diff a bit
Harbormaster completed remote builds in B39080: Diff 88878.May 7 2021, 9:52 PM
otis updated this revision to Diff 88879.May 7 2021, 9:53 PM
  • rpi_ft5406: Minor style cleanup.
Harbormaster completed remote builds in B39081: Diff 88879.May 7 2021, 9:54 PM
manu added a subscriber: manu.May 7 2021, 9:55 PM

LGTM, just one comment and we're good.

sys/arm/broadcom/bcm2835/bcm2835_ft5406.c
138

I think you can drop this compatible, this was only used in our DTS a few years ago.

otis updated this revision to Diff 88880.May 7 2021, 10:03 PM
  • rpi_ft5406: Only chek for raspberrypi,firmware-ts
otis marked an inline comment as done.May 7 2021, 10:03 PM
Harbormaster completed remote builds in B39082: Diff 88880.May 7 2021, 10:04 PM
manu accepted this revision.May 7 2021, 10:08 PM
This revision is now accepted and ready to land.May 7 2021, 10:08 PM
Closed by commit rGc2c9ef3cedf6: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen (authored by otis). · Explain WhyMay 9 2021, 10:14 AM
This revision was automatically updated to reflect the committed changes.
otis added a commit: rGc2c9ef3cedf6: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen.
otis added a commit: rGe7cd56cfe037: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen.May 23 2021, 1:33 PM
otis added a commit: rG0f12b394faa1: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen.May 23 2021, 1:35 PM
otis added a commit: rGc988a558fafe: rpi_ft5406: Recognize raspberrypi,firmware-ts touchscreen.May 23 2021, 1:41 PM

Revision Contents
Changeset List

PathSize
sys/
arm/
broadcom/
bcm2835/
4 lines

Diff 88907

View Options

sys/arm/broadcom/bcm2835/bcm2835_ft5406.c

Loading...