Page MenuHomeFreeBSD
Differential D30026

pf: Fix IP checksum on reassembly
ClosedPublic
Actions

Authored by kp on Apr 28 2021, 12:58 PM.
Tags
None
Referenced Files
F150430020: D30026.id.diff
Wed, Apr 1, 4:27 AM
F150356010: D30026.id88313.diff
Tue, Mar 31, 12:05 PM
Unknown Object (File)
Tue, Mar 31, 12:25 AM
Unknown Object (File)
Fri, Mar 27, 12:56 PM
Unknown Object (File)
Thu, Mar 26, 1:48 PM
Unknown Object (File)
Tue, Mar 24, 1:59 AM
Unknown Object (File)
Sat, Mar 21, 11:47 PM
Unknown Object (File)
Thu, Mar 19, 7:37 AM
View All Files
Subscribers
farrokhi
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
Commits
rG70e8fe5eee7c: pf: Fix IP checksum on reassembly
rGaf1b05bb32b5: pf: Fix IP checksum on reassembly
rG055c55abefbe: pf: Fix IP checksum on reassembly
Summary

If we reassemble a packet we modify the IP header (to set the length and
remove the fragment offset information), but we failed to update the
checksum. On certain setups (mostly where we did not re-fragment again
afterwards) this could lead to us sending out packets with incorrect
checksums.

PR: 255432
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38906
Build 35795: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
5 lines

Diff 88313

View Options

sys/netpfil/pf/pf_norm.c

Loading...