Page MenuHomeFreeBSD
Differential D29989

pf tests: Test automatically generated tables
ClosedPublic
Actions

Authored by kp on Apr 26 2021, 11:45 AM.
Tags
None
Referenced Files
F110321928: D29989.diff
Sun, Feb 16, 7:15 PM
Unknown Object (File)
Thu, Feb 6, 12:55 AM
Unknown Object (File)
Tue, Jan 28, 5:45 PM
Unknown Object (File)
Tue, Jan 28, 5:43 PM
Unknown Object (File)
Thu, Jan 23, 12:59 PM
Unknown Object (File)
Wed, Jan 22, 3:11 PM
Unknown Object (File)
Jan 15 2025, 11:42 AM
Unknown Object (File)
Jan 15 2025, 8:46 AM
View All 63 Files
Subscribers
farrokhi
imp
melifaro

Details

Reviewers
melifaro
Group Reviewers
network
Commits
rGa599304a6c7f: pf tests: Test automatically generated tables
rGaacfedcef1b2: pf tests: Test automatically generated tables
rG08d77308211f: pf tests: Test automatically generated tables
Summary

Add a test case where the pfctl optimizer will generate a table
automatically. These tables have long names, which we accidentally broke
in the nvlist ADDRULE ioctl.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Apr 26 2021, 11:45 AM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptApr 26 2021, 11:45 AM
kp requested review of this revision.Apr 26 2021, 11:45 AM
Harbormaster completed remote builds in B38862: Diff 88161.Apr 26 2021, 11:45 AM
melifaro accepted this revision as: melifaro.Apr 26 2021, 11:57 AM
melifaro added inline comments.
tests/sys/netpfil/pf/table.sh
152

Double quotes for consistebcy?

This revision is now accepted and ready to land.Apr 26 2021, 11:57 AM
kp updated this revision to Diff 88165.Apr 26 2021, 12:30 PM
  • change quotes
This revision now requires review to proceed.Apr 26 2021, 12:30 PM
Harbormaster completed remote builds in B38863: Diff 88165.Apr 26 2021, 12:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2021, 4:10 PM
Closed by commit rG08d77308211f: pf tests: Test automatically generated tables (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG08d77308211f: pf tests: Test automatically generated tables.
kp added a commit: rGaacfedcef1b2: pf tests: Test automatically generated tables.May 10 2021, 7:50 PM
kp added a commit: rGa599304a6c7f: pf tests: Test automatically generated tables.

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
pf/
38 lines

Diff 88187

View Options

tests/sys/netpfil/pf/table.sh

Loading...