Page MenuHomeFreeBSD
Differential D29877

net/qt5-network: fix build with LibreSSL 3.3.2
ClosedPublic
Actions

Authored by vishwin on Apr 21 2021, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 2:48 PM
Unknown Object (File)
Fri, Sep 4, 11:48 PM
Unknown Object (File)
Fri, Sep 4, 7:58 PM
Unknown Object (File)
Thu, Sep 3, 4:30 PM
Unknown Object (File)
Tue, Sep 1, 11:19 PM
Unknown Object (File)
Tue, Sep 1, 4:19 PM
Unknown Object (File)
Sun, Aug 30, 5:33 PM
Unknown Object (File)
Sun, Aug 30, 4:17 PM
View All Files
Subscribers
mat
tcberner

Details

Reviewers
tcberner
fluffy
arrowd
Group Reviewers
kde
Commits
R11:49012339a1f2: net/qt5-network: fix build with LibreSSL 3.3.2
Summary

Since LibreSSL's libssl now exposes DTLS1_2_VERSION, configure detects DTLS support which changes the DTLSv1_listen(3) signature to one that LibreSSL has never supported. Force disable DTLS feature for SSL_DEFAULT=libressl or libressl-devel.

Based on: https://github.com/openbsd/ports/commit/9942e8d28c4ec59d8d4a20b8bf219b10573c1f31

Test Plan

Passes testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38744
Build 35633: arc lint + arc unit

Event Timeline

vishwin created this revision.Apr 21 2021, 6:12 AM
Herald added a subscriber: mat. · View Herald TranscriptApr 21 2021, 6:12 AM
vishwin requested review of this revision.Apr 21 2021, 6:12 AM
Harbormaster completed remote builds in B38743: Diff 87849.Apr 21 2021, 6:12 AM
vishwin changed the repository for this revision from rP FreeBSD ports repository to R11 FreeBSD ports repository.Apr 21 2021, 6:13 AM
tcberner added a subscriber: tcberner.Apr 21 2021, 7:23 AM
tcberner added inline comments.
net/qt5-network/Makefile
31

^ ${SSL_DEFAULT:Mlibressl*} might work

vishwin updated this revision to Diff 87851.Apr 21 2021, 7:57 AM

Compact syntax for LibreSSL conditional, works

Harbormaster completed remote builds in B38744: Diff 87851.Apr 21 2021, 7:57 AM
vishwin marked an inline comment as done.Apr 21 2021, 7:58 AM
vishwin added reviewers: tcberner, fluffy, arrowd.May 4 2021, 11:47 PM
Approved by: ? (kde), ? (mentor)
fluffy accepted this revision.May 5 2021, 7:39 AM

Ship it!

This revision is now accepted and ready to land.May 5 2021, 7:39 AM
Closed by commit R11:49012339a1f2: net/qt5-network: fix build with LibreSSL 3.3.2 (authored by vishwin). · Explain WhyMay 5 2021, 11:51 AM
This revision was automatically updated to reflect the committed changes.
vishwin added a commit: R11:49012339a1f2: net/qt5-network: fix build with LibreSSL 3.3.2.

Revision Contents
Changeset List

PathSize
net/
qt5-network/
5 lines

Diff 87851

View Options

net/qt5-network/Makefile

Loading...