pf: Refactor state killing
ClosedPublic
Actions

Authored by kp on Apr 16 2021, 5:52 PM.

Details

Reviewers

Group Reviewers

Commits

rG6210e809da13: pf: Refactor state killing
rG3a1c3e11ac11: pf: Refactor state killing
rG586aab9e0aa6: pf: Refactor state killing

Summary

Extract the state killing code from pfioctl() and rephrase the filtering
conditions for readability.

No functional change intended.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38629
Build 35518: arc lint + arc unit

Event Timeline

kp created this revision.Apr 16 2021, 5:52 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptApr 16 2021, 5:52 PM

kp requested review of this revision.Apr 16 2021, 5:52 PM

Harbormaster completed remote builds in B38626: Diff 87556.Apr 16 2021, 5:52 PM

eri requested changes to this revision.Apr 16 2021, 7:29 PM

eri added a subscriber: eri.

eri added inline comments.

sys/netpfil/pf/pf_ioctl.c
2513	You should invert the check here to !=

This revision now requires changes to proceed.Apr 16 2021, 7:29 PM

Fix issue found by eri

Harbormaster completed remote builds in B38629: Diff 87566.Apr 16 2021, 8:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2021, 11:23 AM

Closed by commit rG586aab9e0aa6: pf: Refactor state killing (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG586aab9e0aa6: pf: Refactor state killing.

kp added a commit: rG3a1c3e11ac11: pf: Refactor state killing.Apr 28 2021, 3:14 PM

kp added a commit: rG6210e809da13: pf: Refactor state killing.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

122 lines

Diff 87566

View Options

pf: Refactor state killingClosedPublicActions