Add a way to specify stripesize and stripeoffset to gnop(8). This makes
it possible to "simulate" 4K media, to eg test alignment handling.
Details
- Reviewers
mav - Group Reviewers
manpages - Commits
- rS287827: Add a way to specify stripesize and stripeoffset to gnop(8). This makes
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 531 Build 531: arc lint + arc unit
Event Timeline
Generally I like it. Just a few comments.
sbin/geom/class/nop/geom_nop.c | ||
---|---|---|
53 | Why 't' and 'T'? any associations I miss? Wouldn't 'p' and 'P' (from "physical") be a bit mode logical? | |
sys/geom/nop/g_nop.c | ||
218 | There is no strict relation between stripesize and MAXPHYS. This limitation exist for logical sector, since we must be able to access at least sector at a time. But stripesize is only an optimization, so we should be able to support even too large values. | |
226 | I would compare stripeoffset to stripesize instead. If stripesize is not zero, stripeoffset should not be bigger then it. |
sys/geom/nop/g_nop.c | ||
---|---|---|
226 | No. Only less. Equal would give the same effect as set to zero. |
sys/geom/nop/g_nop.c | ||
---|---|---|
219 | Wrong. It should be: if (stripesize != 0 && stripeoffset >= stripesize) { |
Please remove this line.