Use if ... else when printing memory attributes
ClosedPublic
Actions

Authored by andrew on Apr 11 2021, 11:41 AM.

Details

Reviewers

Commits

rGa0dd2317e8f5: Use if ... else when printing memory attributes
rG15221c552b3c: Use if ... else when printing memory attributes

Summary

In vmstat there is a switch statement that converts these attributes to
a string. As some values can be duplicate we have to hide these from
userspace.

Replace this switch statement with an if ... else macro that lets us
repeat values without a compiler error.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Apr 11 2021, 11:41 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 11 2021, 11:41 AM

andrew requested review of this revision.Apr 11 2021, 11:41 AM

Harbormaster completed remote builds in B38497: Diff 87248.Apr 11 2021, 11:41 AM

andrew mentioned this in D29692: Create VM_MEMATTR_DEVICE on all architectures.Apr 11 2021, 11:42 AM

kib accepted this revision.Apr 11 2021, 11:48 AM

This revision is now accepted and ready to land.Apr 11 2021, 11:48 AM

Closed by commit rG15221c552b3c: Use if ... else when printing memory attributes (authored by andrew). · Explain WhyApr 11 2021, 1:38 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG15221c552b3c: Use if ... else when printing memory attributes.

I suppose if this had been an enum there would have been value in the switch to avoid missing new values in the future, but it's not an enum.

andrew added a commit: rGa0dd2317e8f5: Use if ... else when printing memory attributes.Jun 12 2021, 2:02 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

vmstat/

vmstat.c

54 lines

Diff 87249

View Options

Use if ... else when printing memory attributesClosedPublicActions