deleting EFI vars with '-' in their name
ClosedPublic
Actions

Authored by imp on Apr 7 2021, 5:59 AM.

Details

Reviewers

markj
jhb

Commits

rGc2d161d30006: efivar: Attempt to fix setting/printing/deleting EFI vars with '-' in their name
rG0292a5c95f14: efivar: Attempt to fix setting/printing/deleting EFI vars with '-' in their name

Summary

Due to how we're parsing UUIDs, we were disallowing setting, printing or
deleting any UEFI variable with a '-' in it when you attempted to do that
operation with the exact name (wildcard reporting was unaffected). Fix the
parser to loop over all the dashes in the name and only give up when all
possible matches are exhausted.

PR: 251025

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Apr 7 2021, 5:59 AM

imp created this revision.

Harbormaster completed remote builds in B38376: Diff 86941.Apr 7 2021, 5:59 AM

imp added reviewers: markj, jhb.Apr 7 2021, 5:59 AM

imp edited the summary of this revision. (Show Details)Apr 7 2021, 6:02 AM

Better error message with full name.

Harbormaster completed remote builds in B38378: Diff 86943.Apr 7 2021, 6:07 AM

markj accepted this revision.Apr 7 2021, 1:24 PM

markj added inline comments.

usr.sbin/efivar/efivar.c
139	If you instead write `if (efi_name_to_guid(name, guid) >= 0) break;`, you can get rid of the `again` flag variable. BTW, efi_name_to_guid(3) is documented as unimplemented. :)