cxgbe(4): Always use the per-VI callout to read interface stats.
ClosedPublic
Actions

Authored by np on Apr 1 2021, 8:43 AM.

Details

Reviewers

Commits

rGe0897d666922: cxgbe(4): Always use the per-VI callout to read interface stats.
rG516fe911a6b7: cxgbe(4): Always use the per-VI callout to read interface stats.

Summary

There is no change in the source of the stats (t4_get_port_stats or
t4_get_vi_stats) but the per-port callout is gone.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

np created this revision.Apr 1 2021, 8:43 AM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 1 2021, 8:43 AM

np requested review of this revision.Apr 1 2021, 8:43 AM

Harbormaster completed remote builds in B38239: Diff 86666.Apr 1 2021, 8:43 AM

jhb added inline comments.Apr 1 2021, 5:30 PM

sys/dev/cxgbe/t4_main.c
6284	This seems a bit odd as it means you will drop/pickup this lock several times. Maybe make the acquire of this lock in vi_refresh_stats() conditional on IS_VF instead and move the assertion here?

np marked an inline comment as done.Apr 1 2021, 5:57 PM

Acquire reg_lock around read_vf_stat instead of in a loop in the function.

Harbormaster completed remote builds in B38258: Diff 86699.Apr 1 2021, 5:59 PM

jhb accepted this revision.Apr 1 2021, 9:20 PM

This revision is now accepted and ready to land.Apr 1 2021, 9:20 PM

Closed by commit rG516fe911a6b7: cxgbe(4): Always use the per-VI callout to read interface stats. (authored by np). · Explain WhyApr 1 2021, 9:26 PM

This revision was automatically updated to reflect the committed changes.

np added a commit: rG516fe911a6b7: cxgbe(4): Always use the per-VI callout to read interface stats..

np added a commit: rGe0897d666922: cxgbe(4): Always use the per-VI callout to read interface stats..May 16 2021, 3:25 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

adapter.h

5 lines

t4_main.c

46 lines

Diff 86712

View Options

sys/dev/cxgbe/adapter.h