Page MenuHomeFreeBSD
Differential D29539

Partially revert r248770.
ClosedPublic
Actions

Authored by dchagin on Apr 1 2021, 7:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 6:50 PM
Unknown Object (File)
Sun, Sep 6, 6:13 PM
Unknown Object (File)
Sun, Sep 6, 1:51 PM
Unknown Object (File)
Sat, Sep 5, 4:53 PM
Unknown Object (File)
Sat, Sep 5, 4:53 PM
Unknown Object (File)
Sat, Sep 5, 10:57 AM
Unknown Object (File)
Sat, Sep 5, 8:16 AM
Unknown Object (File)
Sat, Sep 5, 7:52 AM
View All Files
Subscribers
dab
imp

Details

Reviewers
jimharris
mav
imp
Commits
rGa83c64a59cf5: Partially revert r248770.
rG02816ecfb935: Partially revert r248770.
rGa78109d5db87: Partially revert r248770.
Summary

nvme_ns_bio_process() is on the path where sleep is prohibited as
g_io_shedule_down() calls THREAD_NO_SLEEPNG() before geom->start().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38259
Build 35148: arc lint + arc unit

Event Timeline

dchagin created this revision.Apr 1 2021, 7:37 PM
Herald added subscribers: dab, imp. · View Herald TranscriptApr 1 2021, 7:37 PM
Harbormaster completed remote builds in B38259: Diff 86705.Apr 1 2021, 7:37 PM
dchagin requested review of this revision.Apr 1 2021, 7:37 PM
dchagin added reviewers: jimharris, mav, imp.Apr 1 2021, 7:38 PM
imp accepted this revision.Apr 1 2021, 8:38 PM

I've never seen this lead to deadlock, but I'm also only ever using nvme with direct dispatch...

This revision is now accepted and ready to land.Apr 1 2021, 8:38 PM
dchagin added a comment.Apr 2 2021, 7:40 AM
In D29539#662228, @imp wrote:

I've never seen this lead to deadlock, but I'm also only ever using nvme with direct dispatch...

10x, seems that I'm first who use nvme under geom o_O

Closed by commit rGa78109d5db87: Partially revert r248770. (authored by dchagin). · Explain WhyApr 2 2021, 8:44 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGa78109d5db87: Partially revert r248770..
dchagin added a commit: rG02816ecfb935: Partially revert r248770..Apr 16 2021, 8:34 AM
dchagin added a commit: rGa83c64a59cf5: Partially revert r248770..Apr 16 2021, 8:36 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
2 lines

Diff 86705

View Options

sys/dev/nvme/nvme_ns.c

Loading...