pci: enhance printf for leaked MSI[-X] vectors
ClosedPublic
Actions

Authored by bz on Mar 23 2021, 4:01 PM.

Details

Reviewers

jhb
grehan

Commits

rG87c6a74dbe94: pci: enhance printf for leaked MSI[-X] vectors
rGa9f0367b04b3: pci: enhance printf for leaked MSI[-X] vectors

Summary

When debugging leaked MSI/MSI-X vectors through LinuxKPI I found
the informational printf unhelpful. Rather than just stating we
leaked also tell how many MSI and MSI-X vectors we leak.

Sponsored-by: The FreeBSD Foundation
Reviewed-by: ...
MFC-after: 2 weeks
Differential Revision:

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Mar 23 2021, 4:01 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2021, 4:01 PM

bz requested review of this revision.Mar 23 2021, 4:01 PM

Harbormaster completed remote builds in B38019: Diff 86205.Mar 23 2021, 4:02 PM

Hmm, we don't list the leaked resources for any other types so that's a bit inconsistent (e.g. we don't list the address or rid's of BARs).

sys/dev/pci/pci.c
5007–5012	I would either say "MSI/MSI-X" or annotate the counts, e.g. "Device leaked MSI vectors: %d (MSI) %d (MSI-X)". OTOH, you can never have both MSI and MSI-X, so another possibility is: if dinfo->cfg.msi.msi_alloc) pci_printf(&dinfo->cfg, "Device leaked %d MSI vectors\n", dinfo->cfg.msi.msi_alloc); else pci_printf(&dinfo->cfg, "Device leaked %d MSI-X vectors\n", dinfo->cfg.msix.msix_alloc);