textproc/git-chglog: Update to 0.13.0
ClosedPublic
Actions

Authored by lcook on Mar 25 2021, 12:59 PM.

Details

Reviewers

tcberner
fernape

Commits

rP569250: textproc/git-chglog: Update to 0.13.0

Summary

Changes: https://github.com/git-chglog/git-chglog/releases/tag/v0.13.0

Test Plan

QA:

portlint: OK (looks fine).
testport: OK (poudriere: 12.2-RELEASE-p4, amd64/i386).

MFH: No (Feature update only).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 38065
Build 34954: arc lint + arc unit

Event Timeline

lcook created this revision.Mar 25 2021, 12:59 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 25 2021, 12:59 PM

lcook requested review of this revision.Mar 25 2021, 12:59 PM

Harbormaster completed remote builds in B38065: Diff 86302.Mar 25 2021, 12:59 PM

LGTM.

Just out of curiosity, why do we need BUILDFLAGS now?

This revision is now accepted and ready to land.Mar 25 2021, 4:16 PM

In D29421#659030, @fernape wrote:

LGTM.

Just out of curiosity, why do we need BUILDFLAGS now?

Versions before this update would hard-code its version string inside the source. So instead, we can pass the appropriate version during the build process via ldflags. See here for the pull-request. It has become a convention nowadays to do this while also making it easier on the maintainer. In some cases, the author of an application forgets to bump the hard-coded value, so this avoids that entirely when packaging up for a system.

Closed by commit rP569250: textproc/git-chglog: Update to 0.13.0 (authored by lcook). · Explain WhyMar 26 2021, 9:11 AM

This revision was automatically updated to reflect the committed changes.

lcook added a commit: rP569250: textproc/git-chglog: Update to 0.13.0.

In D29421#659205, @lcook wrote:

In D29421#659030, @fernape wrote:

LGTM.

Just out of curiosity, why do we need BUILDFLAGS now?

Versions before this update would hard-code its version string inside the source. So instead, we can pass the appropriate version during the build process via ldflags. See here for the pull-request. It has become a convention nowadays to do this while also making it easier on the maintainer. In some cases, the author of an application forgets to bump the hard-coded value, so this avoids that entirely when packaging up for a system.