Page MenuHomeFreeBSD

textproc/git-chglog: Update to 0.13.0
ClosedPublic

Authored by lcook on Mar 25 2021, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 8:31 PM
Unknown Object (File)
Dec 20 2023, 6:01 AM
Unknown Object (File)
Aug 15 2023, 7:56 AM
Unknown Object (File)
Jul 9 2023, 11:16 PM
Unknown Object (File)
Jun 17 2023, 2:57 PM
Unknown Object (File)
Jun 16 2023, 3:57 AM
Unknown Object (File)
Jun 14 2023, 6:40 PM
Unknown Object (File)
Apr 6 2023, 3:00 PM
Subscribers

Details

Summary
Test Plan

QA:

  • portlint: OK (looks fine).
  • testport: OK (poudriere: 12.2-RELEASE-p4, amd64/i386).

MFH: No (Feature update only).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38065
Build 34954: arc lint + arc unit

Event Timeline

LGTM.

Just out of curiosity, why do we need BUILDFLAGS now?

This revision is now accepted and ready to land.Mar 25 2021, 4:16 PM

LGTM.

Just out of curiosity, why do we need BUILDFLAGS now?

Versions before this update would hard-code its version string inside the source. So instead, we can pass the appropriate version during the build process via ldflags. See here for the pull-request. It has become a convention nowadays to do this while also making it easier on the maintainer. In some cases, the author of an application forgets to bump the hard-coded value, so this avoids that entirely when packaging up for a system.

This revision was automatically updated to reflect the committed changes.

LGTM.

Just out of curiosity, why do we need BUILDFLAGS now?

Versions before this update would hard-code its version string inside the source. So instead, we can pass the appropriate version during the build process via ldflags. See here for the pull-request. It has become a convention nowadays to do this while also making it easier on the maintainer. In some cases, the author of an application forgets to bump the hard-coded value, so this avoids that entirely when packaging up for a system.

Thanks for the explanation!