ip_divert: check that PCB is still valid after INP_RLOCK taking
ClosedPublic
Actions

Authored by ae on Mar 25 2021, 8:56 AM.

Details

Reviewers

None

Group Reviewers

Commits

rG38c299fe8562: ipdivert: check that PCB is still valid after taking INPCB_RLOCK.
rG6b8c65318e81: ipdivert: check that PCB is still valid after taking INPCB_RLOCK.
rGc80a4b76ceac: ipdivert: check that PCB is still valid after taking INPCB_RLOCK.

Summary

We are inspecting PCBs of divert sockets under NET_EPOCH section,
but PCB could be already deleted and we should check INP_FREED flag
when we took INP_RLOCK.

PR: 254478

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38064
Build 34953: arc lint + arc unit

Event Timeline

ae created this revision.Mar 25 2021, 8:56 AM

ae held this revision as a draft.

Herald added subscribers: melifaro, imp. · View Herald TranscriptMar 25 2021, 8:56 AM

Harbormaster completed remote builds in B38064: Diff 86294.Mar 25 2021, 8:56 AM

ae published this revision for review.Mar 25 2021, 8:57 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2021, 9:43 AM

Closed by commit rGc80a4b76ceac: ipdivert: check that PCB is still valid after taking INPCB_RLOCK. (authored by ae). · Explain Why

This revision was automatically updated to reflect the committed changes.

ae added a commit: rGc80a4b76ceac: ipdivert: check that PCB is still valid after taking INPCB_RLOCK..

ae added a commit: rG6b8c65318e81: ipdivert: check that PCB is still valid after taking INPCB_RLOCK..Apr 6 2021, 6:50 AM

ae added a commit: rG38c299fe8562: ipdivert: check that PCB is still valid after taking INPCB_RLOCK..

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_divert.c

4 lines

Diff 86294

View Options

ip_divert: check that PCB is still valid after INP_RLOCK takingClosedPublicActions