Page MenuHomeFreeBSD

lib/libc/net/nsdispatch.c: Fix missing unlock and add locking annotations
ClosedPublic

Authored by arichardson on Mar 22 2021, 10:27 AM.
Tags
None
Referenced Files
F160828519: D29372.diff
Sun, Jun 28, 8:39 AM
Unknown Object (File)
Tue, Jun 9, 11:53 AM
Unknown Object (File)
Mon, Jun 8, 2:23 AM
Unknown Object (File)
May 7 2026, 12:17 PM
Unknown Object (File)
May 6 2026, 12:25 AM
Unknown Object (File)
Apr 30 2026, 3:30 PM
Unknown Object (File)
Apr 29 2026, 7:52 PM
Unknown Object (File)
Apr 29 2026, 9:24 AM
Subscribers

Details

Summary

The error cases (goto fin) of _nsdispatch were missing the unlock.

This change also drops the checks for __isthreaded since the pthread stubs
are already no-ops if threads are not being used. Dropping those conditionals
allows clang's thread safety analysis to deal with the file and also makes
the code a bit more readable. While touching the file also add a few more
assertions in debug mode that the right locks are held.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37986
Build 34875: arc lint + arc unit