Page MenuHomeFreeBSD
Differential D29370

usr.sbin/services_mkdb: plug memory leak when line was blank.
ClosedPublic
Actions

Authored by delphij on Mar 22 2021, 2:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 7:15 AM
Unknown Object (File)
Mar 22 2025, 5:46 PM
Unknown Object (File)
Mar 19 2025, 2:02 AM
Unknown Object (File)
Mar 14 2025, 9:45 AM
Unknown Object (File)
Mar 14 2025, 2:59 AM
Unknown Object (File)
Mar 13 2025, 9:59 PM
Unknown Object (File)
Feb 24 2025, 6:24 PM
Unknown Object (File)
Feb 9 2025, 7:41 AM
View All 88 Files
Subscribers
imp

Details

Reviewers
emaste
kevlo
christos_netbsd.org
bapt
Commits
rG5d02b30ebd88: usr.sbin/services_mkdb: plug memory leak when line was blank.
rG18f3c5fe9207: usr.sbin/services_mkdb: plug memory leak when line was blank.
Summary

plug memory leak whe nline was blank.

Test Plan

services_mkdb -u services

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37983
Build 34872: arc lint + arc unit

Revision Contents
Changeset List

PathSize
usr.sbin/
services_mkdb/
10 lines

Diff 86121

View Options

usr.sbin/services_mkdb/uniq.c

Show First 20 Lines • Show All 84 Lines • ▼ Show 20 Lines
MODULE_DEPEND(nvme, cam, 1, 1, 1); MODULE_DEPEND(nvme, cam, 1, 1, 1);
static struct _pcsid static struct _pcsid
{ {
uint32_t devid; uint32_t devid;
int match_subdevice; int match_subdevice;
uint16_t subdevice; uint16_t subdevice;
const char *desc; const char *desc;
uint32_t quirks;
} pci_ids[] = { } pci_ids[] = {
{ 0x01118086, 0, 0, "NVMe Controller" }, { 0x01118086, 0, 0, "NVMe Controller" },
{ IDT32_PCI_ID, 0, 0, "IDT NVMe Controller (32 channel)" }, { IDT32_PCI_ID, 0, 0, "IDT NVMe Controller (32 channel)" },
{ IDT8_PCI_ID, 0, 0, "IDT NVMe Controller (8 channel)" }, { IDT8_PCI_ID, 0, 0, "IDT NVMe Controller (8 channel)" },
{ 0x09538086, 1, 0x3702, "DC P3700 SSD" }, { 0x09538086, 1, 0x3702, "DC P3700 SSD" },
{ 0x09538086, 1, 0x3703, "DC P3700 SSD [2.5\" SFF]" }, { 0x09538086, 1, 0x3703, "DC P3700 SSD [2.5\" SFF]" },
{ 0x09538086, 1, 0x3704, "DC P3500 SSD [Add-in Card]" }, { 0x09538086, 1, 0x3704, "DC P3500 SSD [Add-in Card]" },
{ 0x09538086, 1, 0x3705, "DC P3500 SSD [2.5\" SFF]" }, { 0x09538086, 1, 0x3705, "DC P3500 SSD [2.5\" SFF]" },
{ 0x09538086, 1, 0x3709, "DC P3600 SSD [Add-in Card]" }, { 0x09538086, 1, 0x3709, "DC P3600 SSD [Add-in Card]" },
{ 0x09538086, 1, 0x370a, "DC P3600 SSD [2.5\" SFF]" }, { 0x09538086, 1, 0x370a, "DC P3600 SSD [2.5\" SFF]" },
{ 0x00031c58, 0, 0, "HGST SN100", QUIRK_DELAY_B4_CHK_RDY },
{ 0x00231c58, 0, 0, "WDC SN200", QUIRK_DELAY_B4_CHK_RDY },
{ 0x05401c5f, 0, 0, "Memblaze Pblaze4", QUIRK_DELAY_B4_CHK_RDY },
{ 0xa821a821, 0, 0, "Samsung PM1725", QUIRK_DELAY_B4_CHK_RDY },
chuckUnsubmitted
Not Done
Inline Actions

Should the device ID be 0xa821144d?

chuck: Should the device ID be `0xa821144d`?
impAuthorUnsubmitted
Not Done
Inline Actions

yup

imp: yup
{ 0xa821a822, 0, 0, "Samsung PM1725a", QUIRK_DELAY_B4_CHK_RDY },
chuckUnsubmitted
Not Done
Inline Actions

Should the device ID be 0xa822144d?

chuck: Should the device ID be `0xa822144d`?
impAuthorUnsubmitted
Not Done
Inline Actions

yup.

imp: yup.
{ 0x00000000, 0, 0, NULL } { 0x00000000, 0, 0, NULL }
}; };
static int static int
nvme_match(uint32_t devid, uint16_t subdevice, struct _pcsid *ep) nvme_match(uint32_t devid, uint16_t subdevice, struct _pcsid *ep)
{ {
if (devid != ep->devid) if (devid != ep->devid)
return 0; return 0;
▲ Show 20 Lines • Show All 124 Lines • ▼ Show 20 Lines printf("cdw0:%08x sqhd:%04x sqid:%04x "
cpl->status.m, cpl->status.dnr); cpl->status.m, cpl->status.dnr);
} }
static int static int
nvme_attach(device_t dev) nvme_attach(device_t dev)
{ {
struct nvme_controller *ctrlr = DEVICE2SOFTC(dev); struct nvme_controller *ctrlr = DEVICE2SOFTC(dev);
int status; int status;
struct _pcsid *ep;
uint32_t devid;
uint16_t subdevice;
devid = pci_get_devid(dev);
subdevice = pci_get_subdevice(dev);
ep = pci_ids;
while (ep->devid) {
if (nvme_match(devid, subdevice, ep))
break;
++ep;
}
ctrlr->quirks = ep->quirks;
status = nvme_ctrlr_construct(ctrlr, dev); status = nvme_ctrlr_construct(ctrlr, dev);
if (status != 0) { if (status != 0) {
nvme_ctrlr_destruct(ctrlr, dev); nvme_ctrlr_destruct(ctrlr, dev);
return (status); return (status);
} }
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines