Paths

Table of Contentst

Differential D29287

Fix node-gyp run time.
ClosedPublic
Actions

Authored by otis on Mar 16 2021, 12:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 1, 6:56 PM

	Unknown Object (File)
	Mon, Nov 24, 2:07 PM

	Unknown Object (File)
	Mon, Nov 24, 9:51 AM

	Unknown Object (File)
	Mon, Nov 24, 9:51 AM

	Unknown Object (File)
	Mon, Nov 24, 9:51 AM

	Unknown Object (File)
	Mon, Nov 24, 9:51 AM

	Unknown Object (File)
	Mon, Nov 24, 8:18 AM

	Unknown Object (File)
	Fri, Nov 14, 3:04 AM

View All 82 Files

Subscribers

Details

Reviewers

osa
swills

Commits

rP568614: textproc/node-re2: Do not build with explicit NODE_PATH
rP568613: devel/node-gyp: Adjust runtime dependency

Summary

Fix node-gyp runtime:
- Link node_modules to package's base directory because node-gyp and node.js packages in general, is looking for node_modules directory in its base directory.
- Pull in www/npm as a runtime dependency, too, as node-gyp requires npm node_modules on run time,
Build textproc/node-re2 without NODE_PATH explicitly defined.

Test Plan

poudriere results:
https://freebsd-current.builder.wilbury.net/build.html?mastername=13cgx64-default&build=2021-03-16_13h22m23s

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 37861
Build 34750: arc lint + arc unit

Event Timeline

otis created this revision.Mar 16 2021, 12:39 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 16 2021, 12:39 PM

otis requested review of this revision.Mar 16 2021, 12:39 PM

Harbormaster completed remote builds in B37860: Diff 85832.Mar 16 2021, 12:39 PM

otis edited the summary of this revision. (Show Details)Mar 16 2021, 12:44 PM

Fix actual linking

Harbormaster completed remote builds in B37861: Diff 85833.Mar 16 2021, 12:50 PM

LGTM.

This revision is now accepted and ready to land.Mar 16 2021, 2:22 PM

Closed by commit rP568613: devel/node-gyp: Adjust runtime dependency (authored by otis). · Explain WhyMar 16 2021, 9:18 PM

This revision was automatically updated to reflect the committed changes.

otis added a commit: rP568613: devel/node-gyp: Adjust runtime dependency.

otis added a commit: rP568614: textproc/node-re2: Do not build with explicit NODE_PATH.

Revision Contents
Changeset List

Path

Size

devel/

node-gyp/

4 lines

1 line

textproc/

node-re2/

4 lines

Diff 85833

devel/node-gyp/Makefile

Loading...

devel/node-gyp/pkg-plist

Loading...

textproc/node-re2/Makefile

Loading...