if_wg: export tx_bytes, rx_bytes, and last_handshake
ClosedPublic
Actions

Authored by kevans on Mar 9 2021, 11:21 AM.

Details

Reviewers

markj
grehan

Commits

rG94dddbfd00b9: if_wg: export tx_bytes, rx_bytes, and last_handshake

Summary

The names are self-explanatory; these are currently only used by the
wg(8) tool, but they are handy data points to have.

MFC after: 3 days
Discussed with: decke

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37689
Build 34578: arc lint + arc unit

Event Timeline

kevans created this revision.Mar 9 2021, 11:21 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 9 2021, 11:21 AM

kevans requested review of this revision.Mar 9 2021, 11:21 AM

Harbormaster completed remote builds in B37689: Diff 85382.Mar 9 2021, 11:21 AM

grehan accepted this revision.Mar 9 2021, 11:38 AM

This revision is now accepted and ready to land.Mar 9 2021, 11:38 AM

markj added inline comments.Mar 9 2021, 2:56 PM

sys/dev/if_wg/module/module.c
487	Why is this conditional?

kevans added inline comments.Mar 9 2021, 3:10 PM

sys/dev/if_wg/module/module.c
487	My working thought process was to avoid the nvpair allocation since the wg(8) side will assume '0' if these are omitted -- their absence is insignificant.

Closed by commit rG94dddbfd00b9: if_wg: export tx_bytes, rx_bytes, and last_handshake (authored by kevans). · Explain WhyMar 9 2021, 7:51 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG94dddbfd00b9: if_wg: export tx_bytes, rx_bytes, and last_handshake.

Revision Contents
Changeset List

Path

Size

sys/

dev/

if_wg/

module/

module.c

21 lines

Diff 85382

View Options

sys/dev/if_wg/module/module.c

if_wg: export tx_bytes, rx_bytes, and last_handshakeClosedPublicActions