Page MenuHomeFreeBSD

linux: support AT_EMPTY_PATH flag in fchownat(2)
ClosedPublic

Authored by trasz on Mar 6 2021, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 5, 1:10 PM
Unknown Object (File)
Sun, Aug 3, 8:52 AM
Unknown Object (File)
Wed, Jul 30, 9:59 AM
Unknown Object (File)
Mon, Jul 28, 6:05 AM
Unknown Object (File)
Sun, Jul 20, 11:14 AM
Unknown Object (File)
Sat, Jul 19, 12:45 PM
Unknown Object (File)
Wed, Jul 16, 2:35 AM
Unknown Object (File)
Tue, Jul 15, 12:03 PM
Subscribers

Details

Summary

This fixes rsyslog package installation scripts in Bionic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37649
Build 34538: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Mar 6 2021, 8:04 PM

I think the flag should be implemented on the FreeBSD side.

Also, your patch does not handle AT_FDCWD case, that is described in the Linux man page.

sys/compat/linux/linux_file.c
1741–1742

You broke detection of the unknown flags.

Fix unknown flag detection, detect AT_FDCWD.

I've considered doing it natively first - that would allow us to support AT_FDCWD with AT_EMPTY_PATH - but after a few hours I gave up. I'd strongly prefer committing this small change instead of making another attempt at understanding namei().

BTW there are more Linux syscalls taking AT_EMPTY_PATH

sys/compat/linux/linux_file.c
1760

Extra ()

This revision is now accepted and ready to land.Apr 15 2021, 12:46 PM
sys/compat/linux/linux_file.c
1760

This is copy/pasted all over the tree; I'll fix it in a later sweep.