Page MenuHomeFreeBSD
Differential D29108

linux: support AT_EMPTY_PATH flag in fchownat(2)
ClosedPublic
Actions

Authored by trasz on Mar 6 2021, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 12:58 AM
Unknown Object (File)
Thu, Apr 17, 8:42 PM
Unknown Object (File)
Tue, Apr 1, 11:36 PM
Unknown Object (File)
Mar 13 2025, 7:31 PM
Unknown Object (File)
Feb 24 2025, 5:35 AM
Unknown Object (File)
Feb 21 2025, 12:38 PM
Unknown Object (File)
Feb 21 2025, 10:45 AM
Unknown Object (File)
Jan 26 2025, 12:24 PM
View All 84 Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Commits
rG1e44a4ea0d4a: linux: support AT_EMPTY_PATH flag in fchownat(2)
rGe47823b8312b: linux: support AT_EMPTY_PATH flag in fchownat(2)
Summary

This fixes rsyslog package installation scripts in Bionic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37642
Build 34531: arc lint + arc unit

Event Timeline

trasz created this revision.Mar 6 2021, 8:04 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 6 2021, 8:04 PM
trasz requested review of this revision.Mar 6 2021, 8:04 PM
Harbormaster completed remote builds in B37642: Diff 85280.Mar 6 2021, 8:05 PM
trasz added reviewers: Linux Emulation, kib.Mar 6 2021, 8:06 PM
kib added a comment.Mar 6 2021, 8:32 PM

I think the flag should be implemented on the FreeBSD side.

Also, your patch does not handle AT_FDCWD case, that is described in the Linux man page.

sys/compat/linux/linux_file.c
1741

You broke detection of the unknown flags.

trasz updated this revision to Diff 85291.Mar 7 2021, 11:59 AM

Fix unknown flag detection, detect AT_FDCWD.

Harbormaster completed remote builds in B37649: Diff 85291.Mar 7 2021, 12:00 PM
trasz added a comment.EditedMar 7 2021, 12:02 PM

I've considered doing it natively first - that would allow us to support AT_FDCWD with AT_EMPTY_PATH - but after a few hours I gave up. I'd strongly prefer committing this small change instead of making another attempt at understanding namei().

trasz updated this revision to Diff 85292.Mar 7 2021, 12:04 PM

Fix warning message.

Harbormaster completed remote builds in B37650: Diff 85292.Mar 7 2021, 12:04 PM
trasz added a comment.Mar 8 2021, 3:26 PM

(Tinderboxed.)

trasz updated this revision to Diff 87480.Apr 15 2021, 12:27 PM

Reimplement.

Harbormaster completed remote builds in B38589: Diff 87480.Apr 15 2021, 12:27 PM
kib accepted this revision.Apr 15 2021, 12:46 PM

BTW there are more Linux syscalls taking AT_EMPTY_PATH

sys/compat/linux/linux_file.c
1756

Extra ()

This revision is now accepted and ready to land.Apr 15 2021, 12:46 PM
trasz added inline comments.Apr 15 2021, 12:51 PM
sys/compat/linux/linux_file.c
1756

This is copy/pasted all over the tree; I'll fix it in a later sweep.

trasz added a comment.Apr 16 2021, 9:55 AM

(Tinderboxed.)

Closed by commit rGe47823b8312b: linux: support AT_EMPTY_PATH flag in fchownat(2) (authored by trasz). · Explain WhyApr 16 2021, 3:29 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rGe47823b8312b: linux: support AT_EMPTY_PATH flag in fchownat(2).
trasz added a commit: rG1e44a4ea0d4a: linux: support AT_EMPTY_PATH flag in fchownat(2).Feb 17 2022, 10:56 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
8 lines
kern/
15 lines
sys/
1 line

Diff 85280

View Options

sys/compat/linux/linux_file.c

Show First 20 Lines • Show All 273 Lines • ▼ Show 20 Lines#ifdef DDB
dbg_resume_dbreg(); dbg_resume_dbreg();
#endif #endif
CTR0(KTR_SMP, "IPI_STOP (restart)"); CTR0(KTR_SMP, "IPI_STOP (restart)");
} }
static void static void
ipi_preempt(void *arg) ipi_preempt(void *arg)
{ {
CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__); CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__);
ehem_freebsd_m5p.comUnsubmitted
Not Done
Inline Actions

This needs to be fixed.

ehem_freebsd_m5p.com: This needs to be fixed.
sched_preempt(curthread); sched_preempt(curthread);
} }
static void static void
ipi_hardclock(void *arg) ipi_hardclock(void *arg)
{ {
CTR1(KTR_SMP, "%s: IPI_HARDCLOCK", __func__); CTR1(KTR_SMP, "%s: IPI_HARDCLOCK", __func__);
ehem_freebsd_m5p.comUnsubmitted
Not Done
Inline Actions

Another problem in need of fixing.

ehem_freebsd_m5p.com: Another problem in need of fixing.
hardclockintr(); hardclockintr();
} }
static void static void
release_aps(void *dummy __unused) release_aps(void *dummy __unused)
{ {
uint32_t loop_counter; uint32_t loop_counter;
if (mp_ncpus == 1) if (mp_ncpus == 1)
return; return;
intr_pic_ipi_setup(IPI_RENDEZVOUS, "rendezvous", ipi_rendezvous, NULL); intr_ipi_setup(IPI_RENDEZVOUS, "rendezvous", ipi_rendezvous, NULL);
intr_pic_ipi_setup(IPI_AST, "ast", ipi_ast, NULL); intr_ipi_setup(IPI_AST, "ast", ipi_ast, NULL);
intr_pic_ipi_setup(IPI_STOP, "stop", ipi_stop, NULL); intr_ipi_setup(IPI_STOP, "stop", ipi_stop, NULL);
intr_pic_ipi_setup(IPI_PREEMPT, "preempt", ipi_preempt, NULL); intr_ipi_setup(IPI_PREEMPT, "preempt", ipi_preempt, NULL);
intr_pic_ipi_setup(IPI_HARDCLOCK, "hardclock", ipi_hardclock, NULL); intr_ipi_setup(IPI_HARDCLOCK, "hardclock", ipi_hardclock, NULL);
atomic_store_rel_int(&aps_ready, 1); atomic_store_rel_int(&aps_ready, 1);
/* Wake the other threads up */ /* Wake the other threads up */
dsb(); dsb();
sev(); sev();
printf("Release APs\n"); printf("Release APs\n");
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines
View Options

sys/kern/vfs_syscalls.c

Show First 20 Lines • Show All 273 Lines • ▼ Show 20 Lines#ifdef DDB
dbg_resume_dbreg(); dbg_resume_dbreg();
#endif #endif
CTR0(KTR_SMP, "IPI_STOP (restart)"); CTR0(KTR_SMP, "IPI_STOP (restart)");
} }
static void static void
ipi_preempt(void *arg) ipi_preempt(void *arg)
{ {
CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__); CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__);
ehem_freebsd_m5p.comUnsubmitted
Not Done
Inline Actions

This needs to be fixed.

ehem_freebsd_m5p.com: This needs to be fixed.
sched_preempt(curthread); sched_preempt(curthread);
} }
static void static void
ipi_hardclock(void *arg) ipi_hardclock(void *arg)
{ {
CTR1(KTR_SMP, "%s: IPI_HARDCLOCK", __func__); CTR1(KTR_SMP, "%s: IPI_HARDCLOCK", __func__);
ehem_freebsd_m5p.comUnsubmitted
Not Done
Inline Actions

Another problem in need of fixing.

ehem_freebsd_m5p.com: Another problem in need of fixing.
hardclockintr(); hardclockintr();
} }
static void static void
release_aps(void *dummy __unused) release_aps(void *dummy __unused)
{ {
uint32_t loop_counter; uint32_t loop_counter;
if (mp_ncpus == 1) if (mp_ncpus == 1)
return; return;
intr_pic_ipi_setup(IPI_RENDEZVOUS, "rendezvous", ipi_rendezvous, NULL); intr_ipi_setup(IPI_RENDEZVOUS, "rendezvous", ipi_rendezvous, NULL);
intr_pic_ipi_setup(IPI_AST, "ast", ipi_ast, NULL); intr_ipi_setup(IPI_AST, "ast", ipi_ast, NULL);
intr_pic_ipi_setup(IPI_STOP, "stop", ipi_stop, NULL); intr_ipi_setup(IPI_STOP, "stop", ipi_stop, NULL);
intr_pic_ipi_setup(IPI_PREEMPT, "preempt", ipi_preempt, NULL); intr_ipi_setup(IPI_PREEMPT, "preempt", ipi_preempt, NULL);
intr_pic_ipi_setup(IPI_HARDCLOCK, "hardclock", ipi_hardclock, NULL); intr_ipi_setup(IPI_HARDCLOCK, "hardclock", ipi_hardclock, NULL);
atomic_store_rel_int(&aps_ready, 1); atomic_store_rel_int(&aps_ready, 1);
/* Wake the other threads up */ /* Wake the other threads up */
dsb(); dsb();
sev(); sev();
printf("Release APs\n"); printf("Release APs\n");
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines
View Options

sys/sys/syscallsubr.h

Show First 20 Lines • Show All 273 Lines • ▼ Show 20 Lines#ifdef DDB
dbg_resume_dbreg(); dbg_resume_dbreg();
#endif #endif
CTR0(KTR_SMP, "IPI_STOP (restart)"); CTR0(KTR_SMP, "IPI_STOP (restart)");
} }
static void static void
ipi_preempt(void *arg) ipi_preempt(void *arg)
{ {
CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__); CTR1(KTR_SMP, "%s: IPI_PREEMPT", __func__);
ehem_freebsd_m5p.comUnsubmitted
Not Done
Inline Actions

This needs to be fixed.

ehem_freebsd_m5p.com: This needs to be fixed.
sched_preempt(curthread); sched_preempt(curthread);
} }
static void static void
ipi_hardclock(void *arg) ipi_hardclock(void *arg)
{ {
CTR1(KTR_SMP, "%s: IPI_HARDCLOCK", __func__); CTR1(KTR_SMP, "%s: IPI_HARDCLOCK", __func__);
ehem_freebsd_m5p.comUnsubmitted
Not Done
Inline Actions

Another problem in need of fixing.

ehem_freebsd_m5p.com: Another problem in need of fixing.
hardclockintr(); hardclockintr();
} }
static void static void
release_aps(void *dummy __unused) release_aps(void *dummy __unused)
{ {
uint32_t loop_counter; uint32_t loop_counter;
if (mp_ncpus == 1) if (mp_ncpus == 1)
return; return;
intr_pic_ipi_setup(IPI_RENDEZVOUS, "rendezvous", ipi_rendezvous, NULL); intr_ipi_setup(IPI_RENDEZVOUS, "rendezvous", ipi_rendezvous, NULL);
intr_pic_ipi_setup(IPI_AST, "ast", ipi_ast, NULL); intr_ipi_setup(IPI_AST, "ast", ipi_ast, NULL);
intr_pic_ipi_setup(IPI_STOP, "stop", ipi_stop, NULL); intr_ipi_setup(IPI_STOP, "stop", ipi_stop, NULL);
intr_pic_ipi_setup(IPI_PREEMPT, "preempt", ipi_preempt, NULL); intr_ipi_setup(IPI_PREEMPT, "preempt", ipi_preempt, NULL);
intr_pic_ipi_setup(IPI_HARDCLOCK, "hardclock", ipi_hardclock, NULL); intr_ipi_setup(IPI_HARDCLOCK, "hardclock", ipi_hardclock, NULL);
atomic_store_rel_int(&aps_ready, 1); atomic_store_rel_int(&aps_ready, 1);
/* Wake the other threads up */ /* Wake the other threads up */
dsb(); dsb();
sev(); sev();
printf("Release APs\n"); printf("Release APs\n");
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines