Page MenuHomeFreeBSD
Differential D28903

tests/sys/netpfil/pf: Add missing python3 requirements
ClosedPublic
Actions

Authored by arichardson on Feb 23 2021, 6:08 PM.
Tags
None
Referenced Files
F132578194: D28903.id84570.diff
Sat, Oct 18, 3:18 AM
Unknown Object (File)
Wed, Oct 15, 2:02 AM
Unknown Object (File)
Wed, Oct 15, 2:02 AM
Unknown Object (File)
Tue, Oct 14, 5:09 PM
Unknown Object (File)
Tue, Oct 14, 5:09 PM
Unknown Object (File)
Tue, Oct 14, 4:46 AM
Unknown Object (File)
Sat, Oct 4, 6:52 AM
Unknown Object (File)
Thu, Oct 2, 5:55 PM
View All Files
Subscribers
farrokhi
imp
melifaro

Details

Reviewers
kp
Commits
rG3150732abb62: tests/sys/netpfil/pf: Add missing python3 requirements
rG98202829d1b3: tests/sys/netpfil/pf: Add missing python3 requirements
Summary

This also fixes a typo in the dup test that caused the head function to
not be called.

Test Plan

tests are now skipped instead of failing in my images without python3.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37329
Build 34218: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 23 2021, 6:08 PM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptFeb 23 2021, 6:08 PM
arichardson requested review of this revision.Feb 23 2021, 6:08 PM
Harbormaster completed remote builds in B37327: Diff 84570.Feb 23 2021, 6:08 PM
kp added inline comments.Feb 23 2021, 6:21 PM
tests/sys/netpfil/pf/dup.sh
37

That wants to be 'scapy', Scapy requires python, but python doesn't require Scapy.

arichardson updated this revision to Diff 84576.Feb 23 2021, 6:57 PM

apply suggested simplification

Harbormaster completed remote builds in B37329: Diff 84576.Feb 23 2021, 6:58 PM
kp accepted this revision.Feb 23 2021, 6:59 PM

Thanks for the fixes.

This revision is now accepted and ready to land.Feb 23 2021, 6:59 PM
Closed by commit rG98202829d1b3: tests/sys/netpfil/pf: Add missing python3 requirements (authored by arichardson). · Explain WhyMar 1 2021, 12:57 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG98202829d1b3: tests/sys/netpfil/pf: Add missing python3 requirements.
arichardson added a commit: rG3150732abb62: tests/sys/netpfil/pf: Add missing python3 requirements.Mar 17 2021, 10:23 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
pf/
1 line
3 lines

Diff 84576

View Options

tests/sys/netpfil/pf/checksum.sh

Loading...
View Options

tests/sys/netpfil/pf/dup.sh

Loading...