Handle negative return values from syncache_expand().
ClosedPublic
Actions

Authored by jhb on Jan 19 2021, 8:28 PM.

Details

Reviewers

Commits

rG1deaad936417: Handle negative return values from syncache_expand().

Summary

These errors do not clear so to NULL, so the existing check was
treating these failures as success. The rest of do_pass_establish()
then tried to use the listen socket as if it was a connection socket
newly created by syncache_expand().

In addition, for negative return values, do not send a RST to the
peer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 19 2021, 8:28 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJan 19 2021, 8:28 PM

jhb requested review of this revision.Jan 19 2021, 8:28 PM

Harbormaster completed remote builds in B36347: Diff 82584.Jan 19 2021, 8:28 PM

jhb added a reviewer: np.Feb 17 2021, 1:28 AM

np accepted this revision.Feb 17 2021, 7:09 PM

This revision is now accepted and ready to land.Feb 17 2021, 7:09 PM

Closed by commit rG1deaad936417: Handle negative return values from syncache_expand(). (authored by jhb). · Explain WhyFeb 17 2021, 9:29 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1deaad936417: Handle negative return values from syncache_expand()..

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

tom/

t4_listen.c

20 lines

Diff 84131

View Options

sys/dev/cxgbe/tom/t4_listen.c

Handle negative return values from syncache_expand().ClosedPublicActions