Page MenuHomeFreeBSD
Differential D28539

chinese/librime: Update to 1.7.2
ClosedPublic
Actions

Authored by khng on Feb 8 2021, 6:36 PM.
Tags
None
Referenced Files
F169404914: D28539.id.diff
Tue, Sep 1, 11:04 AM
F169244702: D28539.diff
Tue, Sep 1, 1:14 AM
Unknown Object (File)
Mon, Aug 31, 3:22 AM
Unknown Object (File)
Mon, Aug 31, 3:11 AM
Unknown Object (File)
Sun, Aug 30, 11:07 AM
Unknown Object (File)
Sat, Aug 29, 10:37 PM
Unknown Object (File)
Fri, Aug 28, 4:48 PM
Unknown Object (File)
Wed, Aug 26, 11:39 AM
View All Files
Subscribers
mat

Details

Reviewers
ygy
lwhsu
Commits
rP564923: chinese/librime: Update to 1.7.2
Summary

Notes:

  • License is corrected
  • pkg-plist is updated to obey sorting order

Submitted by: Ka Ho Ng
Sponsored by: The FreeBSD Foundation

Test Plan

poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Feb 8 2021, 6:36 PM
Herald added a subscriber: mat. · View Herald TranscriptFeb 8 2021, 6:36 PM
khng requested review of this revision.Feb 8 2021, 6:36 PM
Harbormaster completed remote builds in B36809: Diff 83556.Feb 8 2021, 6:37 PM
ygy accepted this revision.Feb 8 2021, 6:51 PM
This revision is now accepted and ready to land.Feb 8 2021, 6:51 PM
lwhsu accepted this revision.Feb 8 2021, 7:01 PM
lwhsu added inline comments.
chinese/librime/pkg-plist
8 ↗(On Diff #83556)

is this shuffle necessary?

khng marked an inline comment as done.Feb 8 2021, 7:21 PM
khng added inline comments.
chinese/librime/pkg-plist
8 ↗(On Diff #83556)

Seems not necessary to me. It is just some cosmetic fix from what's suggested by makeplist and it also looks good in my eye.

khng marked an inline comment as done.Feb 8 2021, 7:24 PM
lwhsu added inline comments.Feb 8 2021, 7:29 PM
chinese/librime/pkg-plist
8 ↗(On Diff #83556)

I think we can follow LANG=C sort

ygy retitled this revision from chinese/zh-librime: Update to 1.7.2 to chinese/librime: Update to 1.7.2.Feb 11 2021, 12:11 AM
Closed by commit rP564923: chinese/librime: Update to 1.7.2 (authored by ygy). · Explain WhyFeb 11 2021, 3:01 AM
This revision was automatically updated to reflect the committed changes.
ygy added a commit: rP564923: chinese/librime: Update to 1.7.2.

Revision Contents
Changeset List

PathSize
head/
chinese/
librime/
4 lines
6 lines
2 lines

Diff 83674

View Options

head/chinese/librime/Makefile

Loading...
View Options

head/chinese/librime/distinfo

Loading...
View Options

head/chinese/librime/pkg-plist

Loading...