Differential D28438

fetch(3); Add support of HTTPS_PROXY/https_proxy environment variables
Needs ReviewPublic
Actions

Authored by yasu on Jan 31 2021, 5:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 2, 4:46 AM

	Unknown Object (File)
	Sat, Aug 1, 7:42 AM

	Unknown Object (File)
	Fri, Jul 31, 2:27 AM

	Unknown Object (File)
	Sun, Jul 26, 6:51 AM

	Unknown Object (File)
	Sun, Jul 26, 12:54 AM

	Unknown Object (File)
	Sat, Jul 25, 10:16 AM

	Unknown Object (File)
	Fri, Jul 24, 6:18 PM

	Unknown Object (File)
	Tue, Jul 21, 8:55 AM

Subscribers

Details

Reviewers

Group Reviewers

Summary

Add support of HTTPS_PROXY/https_proxy environment variables. They
works similar to FTP_PROXY/ftp_proxy environment variables for FTP
scheme. That is, if scheme of request URL is "https" fetch(3) checks
if following environment variables are set in this order.

HTTPS_PROXY
https_proxy
HTTP_PROXY
http_proxy

And the value of first one set is used as setting of proxy for https.

Test Plan

It isn't possbile test it with unit test because web server and proxy
are required to test. I've been using this patch with -CURRENT and
it seems to work fine at least for me.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36639
Build 33528: arc lint + arc unit

Event Timeline

yasu created this revision.Jan 31 2021, 5:15 PM

Herald added a reviewer: manpages. · View Herald TranscriptJan 31 2021, 5:15 PM

Herald added a subscriber: imp. · View Herald Transcript

yasu requested review of this revision.Jan 31 2021, 5:15 PM

Harbormaster completed remote builds in B36639: Diff 83185.Jan 31 2021, 5:15 PM

Couple of minor nits-- if they're fixed (or if HTTP is correct above) then fine for manpages.

.Dd bump on commit :)

lib/libfetch/fetch.3
659	HTTP or HTTPS?
868	We use the serial comma.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

22 lines

32 lines

Diff 83185

lib/libfetch/fetch.3

Loading...

lib/libfetch/http.c

Loading...