sysutils/dmidecode: expand platform support
ClosedPublic
Actions

Authored by mhorne on Jan 19 2021, 8:48 PM.

Details

Reviewers

sunpoet
lwhsu
emaste

Commits

rP562225: sysutils/dmidecode: expand platform support

Summary

SMBIOS data is made available on all EFI platforms, including arm64,
arm, and riscv. Allow the port to be built for these architectures,
excluding the x86-specific utilities.

Test Plan

Output from my rockpro64, running u-boot:

# dmidecode 3.3
# SMBIOS entry point at 0xf0f0e000
Found SMBIOS entry point in EFI, reading table from /dev/mem.
SMBIOS 3.0 present.
7 structures occupying 264 bytes.
Table at 0xF0F0E020.

Handle 0x0000, DMI type 0, 24 bytes
BIOS Information
        Vendor: U-Boot
        Version: 2020.07
        Release Date: 11/05/2020
        ROM Size: 64 kB
        Characteristics:
                PCI is supported
                BIOS is upgradeable
                Selectable boot is supported
                I2O boot is supported
                Targeted content distribution is supported

Handle 0x0001, DMI type 1, 27 bytes
System Information
        Manufacturer: pine64
        Product Name: rockpro64_rk3399
        Version: Not Specified
        Serial Number: ca0a9ce6f338afc0
        UUID: 61306163-6339-3665-6633-333861666330
        Wake-up Type: Reserved
        SKU Number: Not Specified
        Family: Not Specified

Handle 0x0002, DMI type 2, 14 bytes
Base Board Information
        Manufacturer: pine64
        Product Name: rockpro64_rk3399
        Version: Not Specified
        Serial Number: Not Specified
        Asset Tag: Not Specified
        Features:
                Board is a hosting board
        Location In Chassis: Not Specified
        Chassis Handle: 0x0000
        Type: Motherboard

Handle 0x0003, DMI type 3, 21 bytes
Chassis Information
        Manufacturer: pine64
        Type: Desktop
        Lock: Not Present
        Version: Not Specified
        Serial Number: Not Specified
        Asset Tag: Not Specified
        Boot-up State: Safe
        Power Supply State: Safe
        Thermal State: Safe
        Security Status: None
        OEM Information: 0x00000000
        Height: Unspecified
        Number Of Power Cords: Unspecified
        Contained Elements: 0

Handle 0x0004, DMI type 4, 48 bytes
Processor Information
        Socket Designation: Not Specified
        Type: Central Processor
        Family: Unknown
        Manufacturer: Unknown
        ID: 00 00 00 00 00 00 00 00
        Version: Unknown
        Voltage: Unknown
        External Clock: Unknown
        Max Speed: Unknown
        Current Speed: Unknown
        Status: Unpopulated
        Upgrade: None
        L1 Cache Handle: Not Provided
        L2 Cache Handle: Not Provided
        L3 Cache Handle: Not Provided
        Serial Number: Not Specified
        Asset Tag: Not Specified
        Part Number: Not Specified
        Characteristics: None

Handle 0x0005, DMI type 32, 11 bytes
System Boot Information
        Status: No errors detected

Handle 0x0006, DMI type 127, 4 bytes
End Of Table

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 36348
Build 33237: arc lint + arc unit

Event Timeline

mhorne created this revision.Jan 19 2021, 8:48 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 19 2021, 8:48 PM

mhorne requested review of this revision.Jan 19 2021, 8:48 PM

Harbormaster completed remote builds in B36348: Diff 82585.Jan 19 2021, 8:48 PM

mhorne edited the test plan for this revision. (Show Details)Jan 19 2021, 8:51 PM

lwhsu accepted this revision.Jan 19 2021, 9:00 PM

This revision is now accepted and ready to land.Jan 19 2021, 9:00 PM

LGTM

I will also need to bump PORTREVISION when committing, yes?

EDIT: confirmed on IRC, the answer is no.

I will also need to bump PORTREVISION when committing, yes?

I don't believe so for cases where there are no changes to existing architectures, and the port was already skipped/broken/always failed to build on the affected architectures. But we should have confirmation from someone sufficiently knowledgeable about ports infrastructure.

Closed by commit rP562225: sysutils/dmidecode: expand platform support (authored by mhorne). · Explain WhyJan 21 2021, 5:32 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rP562225: sysutils/dmidecode: expand platform support.