cat: restore errno
ClosedPublic
Actions

Authored by oshogbo on Jan 15 2021, 8:43 PM.

Tags

None

Referenced Files

	F153740171: D28185.id.diff
	Thu, Apr 23, 8:35 AM

	F153699003: D28185.id82341.diff
	Thu, Apr 23, 12:58 AM

	F153692545: D28185.id82338.diff
	Wed, Apr 22, 11:35 PM

	Unknown Object (File)
	Tue, Apr 21, 4:31 PM

	Unknown Object (File)
	Tue, Apr 21, 6:26 AM

	Unknown Object (File)
	Tue, Apr 21, 4:40 AM

	Unknown Object (File)
	Tue, Apr 21, 12:26 AM

	Unknown Object (File)
	Mon, Apr 20, 10:19 PM

View All Files

Subscribers

imp

Details

Reviewers

markj
emaste

Commits

rG6e8062c855d1: cat: persistent errno

Summary

There is no guarantee that after close(2)/free the errno will be
persist. The caller of the udom_open function depends on the errno to
report errors.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

oshogbo created this revision.Jan 15 2021, 8:43 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 15 2021, 8:43 PM

oshogbo requested review of this revision.Jan 15 2021, 8:43 PM

Harbormaster completed remote builds in B36243: Diff 82338.Jan 15 2021, 8:43 PM

oshogbo added reviewers: markj, emaste.Jan 15 2021, 8:44 PM

markj added inline comments.Jan 15 2021, 8:47 PM

bin/cat/cat.c
501–502	What about this path?

Ah... Thanks @markj!

Harbormaster completed remote builds in B36244: Diff 82341.Jan 15 2021, 8:51 PM

markj accepted this revision.Jan 15 2021, 9:00 PM

This revision is now accepted and ready to land.Jan 15 2021, 9:00 PM

Closed by commit rG6e8062c855d1: cat: persistent errno (authored by oshogbo). · Explain WhyJan 16 2021, 11:58 AM

This revision was automatically updated to reflect the committed changes.

oshogbo added a commit: rG6e8062c855d1: cat: persistent errno.

Revision Contents
Changeset List

Path

Size

bin/

cat/

cat.c

11 lines

Diff 82359

View Options

cat: restore errnoClosedPublicActions