Page MenuHomeFreeBSD
Differential D27540

last(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Dec 10 2020, 3:56 PM.
Tags
None
Referenced Files
F113868630: D27540.id80523.diff
Fri, Apr 4, 8:47 PM
Unknown Object (File)
Sun, Mar 9, 12:01 PM
Unknown Object (File)
Mar 6 2025, 2:54 AM
Unknown Object (File)
Mar 4 2025, 5:27 PM
Unknown Object (File)
Mar 3 2025, 3:03 PM
Unknown Object (File)
Mar 3 2025, 2:24 PM
Unknown Object (File)
Feb 28 2025, 10:49 AM
Unknown Object (File)
Feb 28 2025, 8:26 AM
View All 64 Files
Subscribers
gbe
imp
Contributor Reviews (src)

Details

Reviewers
gbe
Group Reviewers
manpages
Commits
rG53c8d22495cf: last(1): Add EXAMPLES section
Summary

Add two simple examples showing the use of the flags: d, n, s, t

While here, reorder cross references properly by section

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./last.1 renders the page properly

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.Dec 10 2020, 3:56 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 10 2020, 3:56 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Dec 10 2020, 3:56 PM
Harbormaster completed remote builds in B35302: Diff 80523.Dec 10 2020, 3:56 PM
fernape edited the summary of this revision. (Show Details)Dec 10 2020, 3:56 PM
gbe added a subscriber: gbe.Dec 10 2020, 4:21 PM
gbe added inline comments.
usr.bin/last/last.1
211

pst/1 would be better since most users, who lock for examples, doesn't have 14 login sessions active.

fernape updated this revision to Diff 80542.Dec 10 2020, 7:00 PM

Cook examples a little to make them more realistic for the final user (gbe@).

Harbormaster completed remote builds in B35314: Diff 80542.Dec 10 2020, 7:00 PM
gbe accepted this revision.Jan 9 2021, 1:47 PM

LGTM

This revision is now accepted and ready to land.Jan 9 2021, 1:47 PM
Closed by commit rG53c8d22495cf: last(1): Add EXAMPLES section (authored by fernape). · Explain WhyJan 9 2021, 5:44 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rG53c8d22495cf: last(1): Add EXAMPLES section.
fernape added a comment.Jan 9 2021, 5:45 PM
In D27540#626957, @gbe wrote:

LGTM

Thanks for the review!

Revision Contents
Changeset List

PathSize
usr.bin/
last/
26 lines

Diff 81961

View Options

usr.bin/last/last.1

Show First 20 Lines • Show All 1,630 Lines • ▼ Show 20 Lines INP_WUNLOCK(in6p); \
{ {
struct ip6_pktopts **optp; struct ip6_pktopts **optp;
/* cannot mix with RFC2292 */ /* cannot mix with RFC2292 */
if (OPTBIT(IN6P_RFC2292)) { if (OPTBIT(IN6P_RFC2292)) {
error = EINVAL; error = EINVAL;
break; break;
} }
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(IPV6_HOPLIMIT, error = ip6_pcbopt(IPV6_HOPLIMIT,
(u_char *)&optval, sizeof(optval), (u_char *)&optval, sizeof(optval),
optp, (td != NULL) ? td->td_ucred : optp, (td != NULL) ? td->td_ucred :
NULL, uproto); NULL, uproto);
INP_WUNLOCK(in6p);
break; break;
} }
case IPV6_RECVHOPLIMIT: case IPV6_RECVHOPLIMIT:
OPTSET2292_EXCLUSIVE(IN6P_HOPLIMIT); OPTSET2292_EXCLUSIVE(IN6P_HOPLIMIT);
break; break;
case IPV6_RECVHOPOPTS: case IPV6_RECVHOPOPTS:
▲ Show 20 Lines • Show All 93 Lines • ▼ Show 20 Lines#endif
break; break;
} }
error = sooptcopyin(sopt, &optval, error = sooptcopyin(sopt, &optval,
sizeof optval, sizeof optval); sizeof optval, sizeof optval);
if (error) if (error)
break; break;
{ {
struct ip6_pktopts **optp; struct ip6_pktopts **optp;
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(optname, error = ip6_pcbopt(optname,
(u_char *)&optval, sizeof(optval), (u_char *)&optval, sizeof(optval),
optp, (td != NULL) ? td->td_ucred : optp, (td != NULL) ? td->td_ucred :
NULL, uproto); NULL, uproto);
INP_WUNLOCK(in6p);
break; break;
} }
case IPV6_2292PKTINFO: case IPV6_2292PKTINFO:
case IPV6_2292HOPLIMIT: case IPV6_2292HOPLIMIT:
case IPV6_2292HOPOPTS: case IPV6_2292HOPOPTS:
case IPV6_2292DSTOPTS: case IPV6_2292DSTOPTS:
case IPV6_2292RTHDR: case IPV6_2292RTHDR:
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines#endif
* later. * later.
*/ */
error = sooptcopyin(sopt, optbuf_storage, error = sooptcopyin(sopt, optbuf_storage,
sizeof(optbuf_storage), 0); sizeof(optbuf_storage), 0);
if (error) if (error)
break; break;
optlen = sopt->sopt_valsize; optlen = sopt->sopt_valsize;
optbuf = optbuf_storage; optbuf = optbuf_storage;
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(optname, optbuf, optlen, error = ip6_pcbopt(optname, optbuf, optlen,
optp, (td != NULL) ? td->td_ucred : NULL, optp, (td != NULL) ? td->td_ucred : NULL,
uproto); uproto);
INP_WUNLOCK(in6p);
break; break;
} }
#undef OPTSET #undef OPTSET
case IPV6_MULTICAST_IF: case IPV6_MULTICAST_IF:
case IPV6_MULTICAST_HOPS: case IPV6_MULTICAST_HOPS:
case IPV6_MULTICAST_LOOP: case IPV6_MULTICAST_LOOP:
case IPV6_JOIN_GROUP: case IPV6_JOIN_GROUP:
▲ Show 20 Lines • Show All 430 Lines • ▼ Show 20 Lines
static int static int
ip6_pcbopt(int optname, u_char *buf, int len, struct ip6_pktopts **pktopt, ip6_pcbopt(int optname, u_char *buf, int len, struct ip6_pktopts **pktopt,
struct ucred *cred, int uproto) struct ucred *cred, int uproto)
{ {
struct ip6_pktopts *opt; struct ip6_pktopts *opt;
if (*pktopt == NULL) { if (*pktopt == NULL) {
*pktopt = malloc(sizeof(struct ip6_pktopts), M_IP6OPT, *pktopt = malloc(sizeof(struct ip6_pktopts), M_IP6OPT,
M_WAITOK); M_NOWAIT);
if (*pktopt == NULL)
return (ENOBUFS);
ip6_initpktopts(*pktopt); ip6_initpktopts(*pktopt);
} }
opt = *pktopt; opt = *pktopt;
return (ip6_setpktopt(optname, buf, len, opt, cred, 1, 0, uproto)); return (ip6_setpktopt(optname, buf, len, opt, cred, 1, 0, uproto));
} }
#define GET_PKTOPT_VAR(field, lenexpr) do { \ #define GET_PKTOPT_VAR(field, lenexpr) do { \
▲ Show 20 Lines • Show All 810 Lines • Show Last 20 Lines