Paths

Table of Contentst

Differential D27798

astro/opencpn: Update to 5.2.4
ClosedPublic
Actions

Authored by rhurlin on Dec 28 2020, 11:51 AM.

Tags

None

Referenced Files

	F106135235: D27798.id81693.diff
	Wed, Dec 25, 11:47 PM

	F106133865: D27798.id81262.diff
	Wed, Dec 25, 11:15 PM

	Unknown Object (File)
	Tue, Dec 3, 5:41 AM

	Unknown Object (File)
	Wed, Nov 27, 11:30 AM

	Unknown Object (File)
	Nov 19 2024, 6:42 PM

	Unknown Object (File)
	Nov 18 2024, 1:52 PM

	Unknown Object (File)
	Nov 18 2024, 9:01 AM

	Unknown Object (File)
	Nov 18 2024, 1:24 AM

View All 85 Files

Subscribers

Details

Reviewers

arrowd
tcberner

Commits

rP560424: astro/opencpn: Update to 5.2.4

Summary

New Plugin Management System
Support for signalK input data streams
New Head-Up Navigation Mode
Docking the Dashboard with dual canvases
Realtime prediction of AIS target location
...

Changelog: https://opencpn.org/OpenCPN/about/ver520.html

Submitted by Andrea Venturoli <ml@netfence.it> (maintainer) in PR 252168

Tested on Poudriere (amd64, i386). 'portlint -AC' is ok.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rhurlin created this revision.Dec 28 2020, 11:51 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 28 2020, 11:51 AM

rhurlin requested review of this revision.Dec 28 2020, 11:51 AM

Harbormaster completed remote builds in B35729: Diff 81262.Dec 28 2020, 11:52 AM

arrowd added inline comments.Dec 28 2020, 12:28 PM

astro/opencpn/Makefile
40 ↗	(On Diff #81262)	This looks suspicious, especially `LDFLAGS` part. Anyways, I'd set `CMAKE_{C,CXX}_FLAGS` instead.

rhurlin added inline comments.Dec 28 2020, 8:48 PM

astro/opencpn/Makefile
40 ↗	(On Diff #81262)	Thanks for the pointer. I am even not sure, if both, LDFLAGS and {C,CXX}FLAGS are needed. At least the port builds and runs fine w/o, as far as I can say. The maintainer tried also and confirms, that it builds for him. He is not able to really test it deeper ATM, because he has not the needed hardware for it.

Unfortunately, it was not possible for the latest changes to be verified by a person with suitable navigation technology.

The maintainer of the port assumes that the current version of the patch works with the navigation hardware and therefore the patch should be committed.

Changes since the last patch version:

Add USE_GL=glu
Comment LDFLAGS settings
Reorder Makefile vars according to portclippy

Harbormaster completed remote builds in B35853: Diff 81508.Jan 2 2021, 4:06 PM

arrowd accepted this revision.Jan 5 2021, 5:36 PM

arrowd added inline comments.

astro/opencpn/Makefile
41 ↗	(On Diff #81508)	What about this? If it is really required, I'd prefer setting it via `CMAKE_{C,CXX}_FLAGS`.

This revision is now accepted and ready to land.Jan 5 2021, 5:36 PM

Closed by commit rP560424: astro/opencpn: Update to 5.2.4 (authored by rhurlin). · Explain WhyJan 5 2021, 8:05 PM

This revision was automatically updated to reflect the committed changes.

rhurlin marked an inline comment as done.

rhurlin added a commit: rP560424: astro/opencpn: Update to 5.2.4.

rhurlin added inline comments.Jan 5 2021, 8:09 PM

astro/opencpn/Makefile
41 ↗	(On Diff #81508)	I also removed CFLAGS and CCFLAGS, after building and testing again. Seems to work as expected.

Revision Contents
Changeset List

Path

Size

head/

astro/

opencpn/

33 lines

6 lines

files/

patch-CMakeLists.txt

6 lines

patch-cmake_TargetSetup.cmake

18 lines

patch-libs_wxcurl_include_wx_curl_thread.h

11 lines

patch-src_PluginPaths.cpp

11 lines

patch-src_chart1.cpp

86 lines

patch-src_glChartCanvas.cpp

11 lines

1993 lines

Diff 81693

head/astro/opencpn/Makefile

Loading...

head/astro/opencpn/distinfo

Loading...

head/astro/opencpn/files/patch-CMakeLists.txt

Loading...

head/astro/opencpn/files/patch-cmake_TargetSetup.cmake

Loading...

head/astro/opencpn/files/patch-libs_wxcurl_include_wx_curl_thread.h

Loading...

head/astro/opencpn/files/patch-src_PluginPaths.cpp

Loading...

head/astro/opencpn/files/patch-src_chart1.cpp

Loading...

head/astro/opencpn/files/patch-src_glChartCanvas.cpp

Loading...

head/astro/opencpn/pkg-plist

Loading...