astro/opencpn: Update to 5.2.4

[rhurlin]

Summary

• New Plugin Management System
• Support for signalK input data streams
• New Head-Up Navigation Mode
• Docking the Dashboard with dual canvases
• Realtime prediction of AIS target location
• ...

Changelog: https://opencpn.org/OpenCPN/about/ver520.html

Submitted by Andrea Venturoli <[e-mail]> (maintainer) in PR 252168

Tested on Poudriere (amd64, i386). 'portlint -AC' is ok.

[arrowd]

astro/opencpn/Makefile

40 ↗

(On Diff #81262)

This looks suspicious, especially LDFLAGS part. Anyways, I'd set CMAKE_{C,CXX}_FLAGS instead.

[rhurlin]

astro/opencpn/Makefile

40 ↗

(On Diff #81262)

Thanks for the pointer. I am even not sure, if both, LDFLAGS and {C,CXX}FLAGS are needed. At least the port builds and runs fine w/o, as far as I can say.

The maintainer tried also and confirms, that it builds for him. He is not able to really test it deeper ATM, because he has not the needed hardware for it.

[rhurlin]

Unfortunately, it was not possible for the latest changes to be verified by a person with suitable navigation technology.

The maintainer of the port assumes that the current version of the patch works with the navigation hardware and therefore the patch should be committed.

Changes since the last patch version:

• Add USE_GL=glu
• Comment LDFLAGS settings
• Reorder Makefile vars according to portclippy

[arrowd]

astro/opencpn/Makefile

41 ↗

(On Diff #81508)

What about this? If it is really required, I'd prefer setting it via CMAKE_{C,CXX}_FLAGS.

[rhurlin]

astro/opencpn/Makefile

41 ↗

(On Diff #81508)

I also removed CFLAGS and CCFLAGS, after building and testing again. Seems to work as expected.