Page MenuHomeFreeBSD

if_vtnet: Defer updating generated MAC address until attached
ClosedPublic

Authored by bryanv on Jan 2 2021, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 8:11 PM
Unknown Object (File)
Wed, Aug 12, 5:26 PM
Unknown Object (File)
Mon, Aug 10, 7:20 AM
Unknown Object (File)
Sat, Aug 8, 11:21 AM
Unknown Object (File)
Fri, Aug 7, 6:40 PM
Unknown Object (File)
Mon, Aug 3, 7:56 PM
Unknown Object (File)
Sun, Jul 26, 4:23 AM
Unknown Object (File)
Sat, Jul 25, 3:38 PM
Subscribers

Details

Summary

This improves spec compliance because the driver is not suppose
to notify the device prior to setting the DRIVER_OK status, which
could happen with the VIRTIO_NET_F_CTRL_MAC_ADDR.

The VIRTIO_NET_F_MAC feature should always be negotiated so would
be a rare situation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35875
Build 32764: arc lint + arc unit

Event Timeline

bryanv held this revision as a draft.
bryanv published this revision for review.Jan 2 2021, 10:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 5:11 AM
This revision was automatically updated to reflect the committed changes.