mvneta: Fix 64-bit MIB reads
ClosedPublic
Actions

Authored by markj on Dec 31 2020, 6:54 PM.

Details

Reviewers

mw
loos

Commits

rG3160b2d53b38: mvneta: Fix 64-bit MIB reads
rGcaf552a60719: mvneta: Fix 64-bit MIB reads

Summary

It appears we must read them as 2 4-byte words, lower address first.
Otherwise both reads return the same value, resulting in bogus byte
counter values.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35827
Build 32716: arc lint + arc unit

Event Timeline

markj created this revision.Dec 31 2020, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 31 2020, 6:54 PM

markj requested review of this revision.Dec 31 2020, 6:54 PM

Harbormaster completed remote builds in B35827: Diff 81437.Dec 31 2020, 6:54 PM

markj added reviewers: mw, loos.Dec 31 2020, 6:54 PM

mw requested changes to this revision.Dec 31 2020, 11:50 PM

mw added inline comments.

sys/dev/neta/if_mvneta.c
1194	Please replace the for loop with mvneta_clear_mib()

This revision now requires changes to proceed.Dec 31 2020, 11:50 PM

Use mvneta_clear_mib().

Harbormaster completed remote builds in B35845: Diff 81484.Jan 1 2021, 8:56 PM

mw requested changes to this revision.Jan 2 2021, 7:39 AM

mw added inline comments.

sys/dev/neta/if_mvneta.c
3543	Sorry for not spotting this before - val is unitialized, so we need to make sure, the upper half of it is not a random data. Please add: `val = 0;` Otherwise LGTM.

This revision now requires changes to proceed.Jan 2 2021, 7:39 AM

markj added inline comments.Jan 2 2021, 7:43 PM

sys/dev/neta/if_mvneta.c
3543	I don't follow. We assign `val = MVNETA_READ_MIB(sc, mib->regnum)` a couple of lines below. The right-hand side of that statement will be promoted to a 64-bit value before the assignment.