Page MenuHomeFreeBSD
Differential D27815

gstat(8): Document interactive commands
ClosedPublic
Actions

Authored by fernape on Dec 29 2020, 7:23 PM.
Tags
None
Referenced Files
F105956441: D27815.diff
Mon, Dec 23, 2:28 AM
Unknown Object (File)
Sun, Nov 24, 11:14 PM
Unknown Object (File)
Nov 20 2024, 11:23 AM
Unknown Object (File)
Nov 18 2024, 1:14 PM
Unknown Object (File)
Nov 18 2024, 1:14 PM
Unknown Object (File)
Nov 18 2024, 1:14 PM
Unknown Object (File)
Nov 18 2024, 1:14 PM
Unknown Object (File)
Nov 18 2024, 12:56 PM
View All 86 Files
Subscribers
0mp
imp
Contributor Reviews (src)

Details

Reviewers
0mp
Group Reviewers
manpages
Commits
rG439862883f48: gstat(8): Bump .Dd
rGcfaa2958dc44: gstat(8): Document interactive keyboard commands
Summary

Comes from PR 251313
gstat(8) accepts <, >, c, f, F and q while in interactive mode.

I just reorder the options so they match the order we have for the flags
description and remove a blank before end of line.

I also tested the commands and they match the descriptions.

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./gstat.8 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35752
Build 32641: arc lint + arc unit

Event Timeline

fernape created this revision.Dec 29 2020, 7:23 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 29 2020, 7:23 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Dec 29 2020, 7:23 PM
Harbormaster completed remote builds in B35752: Diff 81321.Dec 29 2020, 7:23 PM
fernape retitled this revision from gstat(8): Document interactive commands Comes from [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251313|PR 251313]] to gstat(8): Document interactive commandsComes from [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251313|PR 251313]].Dec 29 2020, 7:25 PM
fernape edited the summary of this revision. (Show Details)
fernape retitled this revision from gstat(8): Document interactive commandsComes from [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251313|PR 251313]] to gstat(8): Document interactive commands.
0mp added a subscriber: 0mp.Jan 4 2021, 7:35 PM
0mp added inline comments.
usr.sbin/gstat/gstat.8
103

just a suggestion, it sounds a bit better to me :)

105

It might be a good idea to use the Ic macro for interactive commands.

fernape updated this revision to Diff 81689.Jan 5 2021, 6:23 PM
  • gstat(8): Use Ic and do some rewording
Harbormaster completed remote builds in B35952: Diff 81689.Jan 5 2021, 6:23 PM
fernape marked 2 inline comments as done.Jan 5 2021, 6:24 PM
fernape added inline comments.
usr.sbin/gstat/gstat.8
105

I didn't know that one.

Thanks!

0mp accepted this revision.Jan 5 2021, 11:08 PM

Thanks!

Just one last typo...

Otherwise, seems ready to be committed. Please remember to dump Dd.

usr.sbin/gstat/gstat.8
103

Typo

This revision is now accepted and ready to land.Jan 5 2021, 11:08 PM
Closed by commit rGcfaa2958dc44: gstat(8): Document interactive keyboard commands (authored by fernape). · Explain WhyJan 6 2021, 6:01 PM
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.
fernape added a commit: rGcfaa2958dc44: gstat(8): Document interactive keyboard commands.
fernape added a commit: rG439862883f48: gstat(8): Bump .Dd.Jan 6 2021, 6:09 PM
fernape added a comment.Jan 6 2021, 6:09 PM
In D27815#625107, @0mp wrote:

Thanks!

Just one last typo...

Otherwise, seems ready to be committed. Please remember to dump Dd.

Done in two commits (forgot to bump Dd before pushing).

Thanks a lot for the review!

Revision Contents
Changeset List

PathSize
usr.sbin/
gstat/
22 lines

Diff 81321

View Options

usr.sbin/gstat/gstat.8

Loading...