Differential D27333

Make cam_getccb(3) zero the whole ccb, not just the header
ClosedPublic
Actions

Authored by trasz on Nov 23 2020, 1:33 PM.

Details

Reviewers

imp

Group Reviewers

manpages

Commits

rG3e404b8c53db: libcam(3): make cam_getccb(3) zero the whole ccb, not just the header

Summary

Make cam_getccb(3) zero the whole ccb, not just the header.

Leaving zeroing to the clients leads to error-prone pointer
tricks (zeroing needs to preserve the CCB header), and this
code is not performance-critical, so there's really no reason
to not do it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Nov 23 2020, 1:33 PM

Herald added a reviewer: manpages. · View Herald TranscriptNov 23 2020, 1:33 PM

trasz requested review of this revision.Nov 23 2020, 1:33 PM

Harbormaster completed remote builds in B34975: Diff 79892.Nov 23 2020, 1:34 PM

trasz added a subscriber: NetApp.Nov 23 2020, 1:34 PM

LGTM, but I'm not authoritative when it comes to CAM.

I believe this is a good change. There's no performance reason to avoid zeroing, and in the kernel we do this:

new_ccb = malloc(sizeof(*new_ccb), M_CAMCCB, M_ZERO|M_WAITOK);

so this makes code that runs in both places more similar.

This revision is now accepted and ready to land.Nov 23 2020, 7:12 PM

(Tinderboxed.)

Closed by commit rG3e404b8c53db: libcam(3): make cam_getccb(3) zero the whole ccb, not just the header (authored by trasz). · Explain WhyDec 29 2020, 2:29 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG3e404b8c53db: libcam(3): make cam_getccb(3) zero the whole ccb, not just the header.

Revision Contents
Changeset List

Path

Size

lib/

libcam/

cam.3

6 lines

camlib.c

3 lines

Diff 81291

View Options

lib/libcam/cam.3