Page MenuHomeFreeBSD
Differential D27691

add couchdb & amqps to /etc/services
ClosedPublic
Actions

Authored by dch on Dec 20 2020, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 3:47 PM
Unknown Object (File)
Sun, Dec 1, 9:28 AM
Unknown Object (File)
Sun, Dec 1, 9:28 AM
Unknown Object (File)
Sun, Dec 1, 9:28 AM
Unknown Object (File)
Sun, Dec 1, 9:28 AM
Unknown Object (File)
Thu, Nov 28, 10:45 PM
Unknown Object (File)
Sat, Nov 23, 10:04 PM
Unknown Object (File)
Nov 20 2024, 10:47 AM
View All 65 Files
Subscribers
imp

Details

Reviewers
pfg
cy
Commits
rG978b10d8ef0f: services: reinstate CouchDB and bring amqps
Summary
  • /etc/services entries are used as names in pf.conf rules
  • couchdb & amqps is in the IANA list
  • databases/couchdb* & net/rabbitmq are in ports, actively maintained, and used

https://reviews.freebsd.org/D23621 did a much-needed cleanup
but this does break a few cases, originally committed in r368712

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35596
Build 32496: arc lint + arc unit

Event Timeline

dch created this revision.Dec 20 2020, 9:48 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 20 2020, 9:48 PM
dch requested review of this revision.Dec 20 2020, 9:48 PM
Harbormaster completed remote builds in B35561: Diff 80987.Dec 20 2020, 9:48 PM
pfg accepted this revision.Dec 20 2020, 11:27 PM

Wow, I should have dropped it by accident: it was surely my intention to keep couchdb in services.

SIze is not an issue anymore. At least not in current.

This revision is now accepted and ready to land.Dec 20 2020, 11:27 PM
pfg added inline comments.Dec 21 2020, 5:16 PM
usr.sbin/services_mkdb/services
1915

You should add the udp service as well as it is in the IANA database:

couchdb 5984 tcp CouchDB
couchdb 5984 udp CouchDB

dch updated this revision to Diff 81035.Dec 22 2020, 7:01 AM

add udp + tcp for amqps + couchdb

This revision now requires review to proceed.Dec 22 2020, 7:01 AM
Harbormaster completed remote builds in B35596: Diff 81035.Dec 22 2020, 7:01 AM
dch retitled this revision from add couchdb to /etc/services to add couchdb & amqps to /etc/services.Dec 22 2020, 7:11 AM
dch edited the summary of this revision. (Show Details)
dch edited the test plan for this revision. (Show Details)
dch marked an inline comment as done.

thanks @pfg this is good my side now. I'm ok to commit this directly once you +1 it.

pfg accepted this revision.Dec 22 2020, 9:12 PM
pfg added inline comments.
usr.sbin/services_mkdb/services
1901
1902

Following IANA, please use the comment for these two:

amqp protocol over TLS/SSL

This revision is now accepted and ready to land.Dec 22 2020, 9:12 PM
Closed by commit rG978b10d8ef0f: services: reinstate CouchDB and bring amqps (authored by pfg). · Explain WhyJan 1 2021, 1:50 AM
This revision was automatically updated to reflect the committed changes.
pfg added a commit: rG978b10d8ef0f: services: reinstate CouchDB and bring amqps.

Revision Contents
Changeset List

PathSize
usr.sbin/
services_mkdb/
4 lines

Diff 81035

View Options

usr.sbin/services_mkdb/services

Loading...