Add ATF functional tests for fstyp(8)
Details
Details
"kyua test"
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Ping? Assuming it works (as in, if it passes, and if it correctly fails when you tweak the code to break it), could you commit it?
Comment Actions
If you're happy with it, I will. I was just waiting for ngie to review it.
On on vacation now; I'll get to this sometime next Wednesdayish.
Comment Actions
General comments:
- Use atf_check copiously to make sure that commands complete successfully.
- Use mkdir -p a/b instead of mkdir a; mkdir a/b .
| usr.sbin/fstyp/tests/fstyp_test.sh | ||
|---|---|---|
| 8–9 ↗ | (On Diff #6241) |
|
| 20–21 ↗ | (On Diff #6241) | Same as above |
Comment Actions
Address ngie's feedback. Use atf_check on almost every line except the ones
that need to redirect stdout, and condense "mkdir foo; mkdir foo/bar" to "mkdir
-p foo/bar".
| usr.sbin/fstyp/tests/fstyp_test.sh | ||
|---|---|---|
| 49 ↗ | (On Diff #6931) | All references to zcat should use bzcat for portability.. |
| usr.sbin/fstyp/Makefile | ||
|---|---|---|
| 47 ↗ | (On Diff #6926) | The extra diffs in this file are caused by svn r284589, which went in after I opened this review. I didn't actually change this file in diff 6926 |
| usr.sbin/fstyp/tests/fstyp_test.sh | ||
| 49 ↗ | (On Diff #6931) | Whoops! I'm surprised that worked at all. I think I started working with gzipped images then switched to bzip2 for better compression. Fix on its way... |