Page MenuHomeFreeBSD
Differential D27496

Improve systat -swap readability and fix display issues
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on Dec 7 2020, 12:24 AM.
Tags
None
Referenced Files
F108807534: D27496.diff
Tue, Jan 28, 3:47 AM
F108755241: D27496.id80741.diff
Mon, Jan 27, 5:59 PM
F108755207: D27496.id80422.diff
Mon, Jan 27, 5:58 PM
F108753714: D27496.id80398.diff
Mon, Jan 27, 5:43 PM
F108710228: D27496.id80399.diff
Mon, Jan 27, 11:26 AM
F108708758: D27496.id80397.diff
Mon, Jan 27, 11:14 AM
F108708251: D27496.id83954.diff
Mon, Jan 27, 11:10 AM
Unknown Object (File)
Fri, Jan 24, 2:05 AM
View All Files
Subscribers
bcr
f20190109_eeeit.de
imp

Details

Reviewers
mr
Group Reviewers
manpages
Commits
rG9d75c569b42b: Improve size readability.
rG70a2e9a3d447: Improve size readability.
rG8d06c3e7a408: Improve size readability.
Summary

Improve size readability.
Preserve more space for swap devise names.
Prevent line overflow with long devise name.
Don't draw a bar when swap is not used at all.
Simplify and optimize code.
Change the label to end at end of 100%.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251655

Test Plan

systat -swap

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35429
Build 32343: arc lint + arc unit

Event Timeline

ota_j.email.ne.jp created this revision.Dec 7 2020, 12:24 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 7 2020, 12:24 AM
ota_j.email.ne.jp requested review of this revision.Dec 7 2020, 12:24 AM
Harbormaster completed remote builds in B35224: Diff 80396.Dec 7 2020, 12:24 AM
ota_j.email.ne.jp edited the summary of this revision. (Show Details)Dec 7 2020, 12:25 AM
ota_j.email.ne.jp updated this revision to Diff 80397.Dec 7 2020, 12:53 AM

Update getbsize man page.

Herald added a reviewer: manpages. · View Herald TranscriptDec 7 2020, 12:53 AM
Harbormaster completed remote builds in B35225: Diff 80397.Dec 7 2020, 12:53 AM
ota_j.email.ne.jp updated this revision to Diff 80398.Dec 7 2020, 12:55 AM

Add a , to .Xr ls

Harbormaster completed remote builds in B35226: Diff 80398.Dec 7 2020, 12:55 AM
ota_j.email.ne.jp updated this revision to Diff 80399.Dec 7 2020, 1:11 AM

Fix style.

Harbormaster completed remote builds in B35227: Diff 80399.Dec 7 2020, 1:11 AM
ota_j.email.ne.jp updated this revision to Diff 80422.Dec 7 2020, 11:22 PM

Fix off-by-one error over 60% and stop extra +1 for percentage.

Harbormaster completed remote builds in B35242: Diff 80422.Dec 7 2020, 11:22 PM
ota_j.email.ne.jp updated this revision to Diff 80741.Dec 16 2020, 5:22 AM

Fix when the number of swap devise is 1.

Harbormaster completed remote builds in B35429: Diff 80741.Dec 16 2020, 5:22 AM
bcr accepted this revision as: manpages.Dec 28 2020, 5:59 PM
bcr added a subscriber: bcr.

OK from manpages.

f20190109_eeeit.de added a subscriber: f20190109_eeeit.de.Feb 15 2021, 7:18 PM
mr accepted this revision.Feb 15 2021, 7:22 PM

Builds, works and looks OK.

This revision is now accepted and ready to land.Feb 15 2021, 7:22 PM
Closed by commit rG8d06c3e7a408: Improve size readability. (authored by mr). · Explain WhyFeb 15 2021, 7:28 PM
This revision was automatically updated to reflect the committed changes.
mr added a commit: rG8d06c3e7a408: Improve size readability..
mr added a commit: rG70a2e9a3d447: Improve size readability..Apr 21 2021, 7:15 PM
mr added a commit: rG9d75c569b42b: Improve size readability..Apr 21 2021, 7:19 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
5 lines
usr.bin/
systat/
1 line
116 lines
21 lines

Diff 80741

View Options

lib/libc/gen/getbsize.3

Loading...
View Options

usr.bin/systat/extern.h

Loading...
View Options

usr.bin/systat/swap.c

Loading...
View Options

usr.bin/systat/sysput.c

Loading...